Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: change the resource address of the default comment component library to unpkg.com #2098

Merged
merged 1 commit into from
May 19, 2022

Conversation

Yhcrown
Copy link

@Yhcrown Yhcrown commented May 19, 2022

What type of PR is this?

/kind optimization

What this PR does / why we need it:

更换了评论组件的默认url

Which issue(s) this PR fixes:

Fixes #2097

Special notes for your reviewer:

Does this PR introduce a user-facing change?

将评论组件的地址由 jsDelivr 更改为 unpkg.com

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2022

@Yhcrown: The label(s) kind/optimization cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind optimization

What this PR does / why we need it:

更换了评论组件的默认url

Which issue(s) this PR fixes:

Fixes #2097

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 19, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@guqing
Copy link
Member

guqing commented May 19, 2022

good job🥳

@ruibaby
Copy link
Member

ruibaby commented May 19, 2022

/kind improvement
/milestone 1.5.x

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label May 19, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone May 19, 2022
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@ruibaby
Copy link
Member

ruibaby commented May 19, 2022

Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@ruibaby
Copy link
Member

ruibaby commented May 19, 2022

/retitle perf: change the resource address of the default comment component library to unpkg.com

@f2c-ci-robot f2c-ci-robot bot changed the title Change the url of comment js perf: change the resource address of the default comment component library to unpkg.com May 19, 2022
@Yhcrown
Copy link
Author

Yhcrown commented May 19, 2022

Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md

明白,不好意思这次图方便就没有创建新分支,下次会注意的。

@JohnNiang
Copy link
Member

Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md

明白,不好意思这次图方便就没有创建新分支,下次会注意的。

建议优化一下 commit,可参考:

git fetch upstream
git reset --soft upstream/master
git add .
// check the changes
git commit -m "your message here"
git push origin feat-comment -f

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@Yhcrown
Copy link
Author

Yhcrown commented May 19, 2022

Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md

明白,不好意思这次图方便就没有创建新分支,下次会注意的。

建议优化一下 commit,可参考:

git fetch upstream
git reset --soft upstream/master
git add .
// check the changes
git commit -m "your message here"
git push origin feat-comment -f

我搞砸了,现在好像优化不了了 TAT

@JohnNiang
Copy link
Member

Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md

明白,不好意思这次图方便就没有创建新分支,下次会注意的。

建议优化一下 commit,可参考:

git fetch upstream
git reset --soft upstream/master
git add .
// check the changes
git commit -m "your message here"
git push origin feat-comment -f

我搞砸了,现在好像优化不了了 TAT

请确保如下命令的结果如下:

$ git remote -v                                                                                                                                                ? INT ? 
origin  [email protected]:JohnNiang/halo.git (fetch)
origin  [email protected]:JohnNiang/halo.git (push)
upstream        [email protected]:halo-dev/halo.git (fetch)
upstream        [email protected]:halo-dev/halo.git (push)

@Yhcrown
Copy link
Author

Yhcrown commented May 19, 2022

嗯呐是这样的

 $ git remote -v
origin  https://github.com/Yhcrown/halo.git (fetch)
origin  https://github.com/Yhcrown/halo.git (push)
upstream        https://github.com/halo-dev/halo.git (fetch)
upstream        https://github.com/halo-dev/halo.git (push)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@JohnNiang
Copy link
Member

/cherrypick release-1.5

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing
Copy link
Member

guqing commented May 19, 2022

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #2099

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@caglam1356
Copy link

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修改默认的评论组件资源地址,目前使用的 jsDelivr 在部分地区已经无法正常访问
6 participants