-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: change the resource address of the default comment component library to unpkg.com #2098
Conversation
@Yhcrown: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
good job🥳 |
src/main/java/run/halo/app/model/properties/CommentProperties.java
Outdated
Show resolved
Hide resolved
/kind improvement |
Hi @Yhcrown ,感谢你的贡献,但这个 PR 似乎包含了以前的提交(不影响合并),建议查阅一下这个文档。https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retitle perf: change the resource address of the default comment component library to unpkg.com |
明白,不好意思这次图方便就没有创建新分支,下次会注意的。 |
建议优化一下 commit,可参考: git fetch upstream
git reset --soft upstream/master
git add .
// check the changes
git commit -m "your message here"
git push origin feat-comment -f |
我搞砸了,现在好像优化不了了 TAT |
请确保如下命令的结果如下: $ git remote -v ? INT ?
origin [email protected]:JohnNiang/halo.git (fetch)
origin [email protected]:JohnNiang/halo.git (push)
upstream [email protected]:halo-dev/halo.git (fetch)
upstream [email protected]:halo-dev/halo.git (push) |
嗯呐是这样的
|
…brary to unpkg.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick release-1.5 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: new pull request created: #2099 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
? |
What type of PR is this?
/kind optimization
What this PR does / why we need it:
更换了评论组件的默认url
Which issue(s) this PR fixes:
Fixes #2097
Special notes for your reviewer:
Does this PR introduce a user-facing change?