add the scrollTop position to high_top #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I attempt to scroll with the mouse wheel causes the list to jump to the top (only in prototype version). This change fixes the problem for me.
|
Please read the contributing section of the readme: Chosen is written in CoffeeScript. the JS files are generated by the CoffeeScript compiler. So doing a change in them is wrong. It would be lost on the next compilation. You need to apply the change in the source instead. |
|
Thanks @jeslopalo. As @stof mentioned, changes have to be made in CoffeeScript as well. This seems important so I've gone ahead and made a new PR doing just that: #1213 Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I attempt to scroll with the mouse wheel causes the list to jump to the top (only in prototype version).
This change fixes the problem for me.