Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll issue in Prototype version #1213

Merged
merged 1 commit into from
May 16, 2013
Merged

Conversation

pfiller
Copy link
Contributor

@pfiller pfiller commented May 14, 2013

@kenearley @stof

As first reported (and fixed) by @jeslopalo in #1201. The Prototype and jQuery versions do not use the same logic and the jQuery version appears to have the correct version.

Currently, high_top is calculated as such.

//jquery
high_top = @result_highlight.position().top + @search_results.scrollTop()

//prototype
high_top = @result_highlight.positionedOffset().top

This change just makes the Prototype version incorporate scrollTop:

high_top = @result_highlight.positionedOffset().top + @search_results.scrollTop

@kenearley
Copy link

This looks fine to me, although I cannot recreate the bug.

pfiller added a commit that referenced this pull request May 16, 2013
@pfiller pfiller merged commit fcaddb8 into master May 16, 2013
@pfiller pfiller deleted the fix-scrollwheel-prototype branch May 16, 2013 15:32
pfiller added a commit that referenced this pull request Jun 3, 2013
Contributing Guidelines #1236
Wrap for attribute in quotes #963b051ecb
Ensure choice count is reflective of actual selected item count. #1171
Delete choice refactor #1232
Fix scroll issue in Prototype version #1213
Use the better supported offsetWidth property to get a fields width #1172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants