Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete choice refactor #1232

Merged
merged 3 commits into from
May 23, 2013
Merged

Delete choice refactor #1232

merged 3 commits into from
May 23, 2013

Conversation

pfiller
Copy link
Contributor

@pfiller pfiller commented May 22, 2013

@kenearley @stof

This refactors the choice_build method to remove the dependence on container ids. This is better for a myriad of reasons but most notably when working with Chosen in memory.

Fixes #1230

@pfiller pfiller mentioned this pull request May 22, 2013
Closed
@stof
Copy link
Collaborator

stof commented May 22, 2013

👍

1 similar comment
@kenearley
Copy link

👍

pfiller added a commit that referenced this pull request May 23, 2013
@pfiller
Merge pull request #1232 from harvesthq/delete-choice-refactor
ba5960d 
Delete choice refactor
@pfiller pfiller merged commit ba5960d into master May 23, 2013
@pfiller pfiller deleted the delete-choice-refactor branch May 23, 2013 15:53
pfiller added a commit that referenced this pull request Jun 3, 2013
@pfiller
Version 0.9.15
e152772 
Contributing Guidelines #1236
Wrap for attribute in quotes #963b051ecb
Ensure choice count is reflective of actual selected item count. #1171
Delete choice refactor #1232
Fix scroll issue in Prototype version #1213
Use the better supported offsetWidth property to get a fields width #1172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting preselected choices from multiselects doesn't work if the select was created outside the DOM
3 participants
@pfiller @stof @kenearley