Add Grunt-powered Jasmine spec runner and a first spec #1462
Conversation
| @@ -92,6 +93,13 @@ module.exports = (grunt) -> | |||
| src: ['public/**/*'] | |||
| dest: "chosen_#{version_tag()}.zip" | |||
|
|
|||
| jasmine: | |||
| jquery: | |||
There was a problem hiding this comment.
We need to have tests for the prototype version as well (and sharing things as much as possible to ensure they behave the same)
There was a problem hiding this comment.
This seems a little tricky but definitely doable. Maybe factoring out the part that creates the actual chosen from the part that interacts with it and does the asserts would be possible.
Is the lack of Prototype tests something that would stop this PR being from being merged?
There was a problem hiding this comment.
Well, it would be better if it could be added. But having tests only for the jQuery version is already better than no tests at all
There was a problem hiding this comment.
@Lenniboy do you have an idea of how we could share specs between the jQuery and Prototype versions as much as possible ? Applying chosen will need to be different in both cases for instance.
Maybe we could load a small test helper with 2 different implementation. One method could be apply_chosen(element, options = {}, which would apply chosen according either the jqury way or the prototype way.
However, the tests themselves are currently relying on jQuery, and I would like to avoid it when testing Prototype (a common mistake done in recent PRs is to use jQuery in the common code where it should not be used). Do you have an idea for this ?
There was a problem hiding this comment.
@stof I have a solution for shared specs in #1487. (from http://pivotallabs.com/drying-up-jasmine-specs-with-shared-behavior/)
|
@Lenniboy what is the status on this PR. Is the current state working or is there some missing stuff to have a working test architecture ? Another thing that should be added in this PR is the config file for Travis, so that tests are launched automatically on each push and on each PR. @harvesthq/chosen-developers should we create a branch in the official repo for this already to finish the work or should it stay in the fork for now ? |
|
I am happy for this to merged. Yes, the test suite isn't covering a lot but I can add the Travis integration in a separate pull request. On Wednesday, 4 September 2013, Christophe Coevoet wrote:
|
Hi Chosen,
as mentioned in #1401 there seems to be some appetite for introducing testing to chosen.
This pull request does exactly that by using the great jasmine spec runner for Grunt. It installs phantomjs through npm and uses that to run the tests. If you're not familiar with phantomjs: it's a headless webkit browser that is as good as a real browser.
The specs themselves are fairly simple so far but I tried to show an example of constructing a chosen element entirely in memory, doing some interactions on it and asserting the expected result.
If you want to run the tests just do a
If you have any questions, please shoot. I'd love to incorporate your feedback into this PR.