search_string_match testing #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koenpunt Regarding yoru test setup sharing the spec, I see an issue here: it forces to put everything in the same spec. This will make it really painful to organize the testsuite. couldn't it be possible to define an helper to apply chosen instead, and to use it in the spec files (shared for both versions) ? |
koenpunt
force-pushed
the
koenpunt-word-boundary-matching
branch
from
aaea71f
to
21fa001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The match testing and regular expression building is now done in separate methods. And I've added a simple spec to test
search_string_match.