chore: Correct locations of various TSS protos #15780

mhess-swl · 2024-10-03T00:23:08Z

Part of #14744

Signed-off-by: Matt Hess <[email protected]>

codecov · 2024-10-03T01:05:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.16%. Comparing base (872ca1a) to head (c4306fe).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #15780   +/-   ##
==========================================
  Coverage      58.16%   58.16%           
- Complexity     21628    21630    +2     
==========================================
  Files           2788     2788           
  Lines         109566   109566           
  Branches       11198    11198           
==========================================
+ Hits           63726    63731    +5     
+ Misses         41979    41975    -4     
+ Partials        3861     3860    -1

Files with missing lines	Coverage Δ
...om/hedera/node/app/tss/schemas/V0560TSSSchema.java	`100.00% <ø> (ø)`

... and 17 files with indirect coverage changes

codacy-production · 2024-10-03T01:05:17Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`872ca1a`)	109383	67477	61.69%
Head commit (`c4306fe`)	109383 (+0)	67481 (+4)	61.69% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#15780)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

hapi/hedera-protobufs/platform/event/tss_message_transaction.proto

edward-swirldslabs

The proto files in this PR need to be deduplicated with the proto files in this commit: b19b06f

The comments on the proto files in this PR are more up to date and need to remain in the deduplicated files.

the package for the proto in the deduplicated files needs to reflect their final location. Likely not platform events since the transactions belong to an application level service.

Signed-off-by: Matt Hess <[email protected]>

Signed-off-by: Matt Hess <[email protected]> # Conflicts: # hapi/hedera-protobufs/services/auxiliary/tss_message_transaction.proto # hapi/hedera-protobufs/services/auxiliary/tss_vote_transaction.proto # hapi/hedera-protobufs/services/transaction_body.proto # hapi/hedera-protobufs/services/tss_message.proto # hapi/hedera-protobufs/services/tss_message_transaction.proto # hapi/hedera-protobufs/services/tss_vote.proto # hapi/hedera-protobufs/services/tss_vote_transaction.proto

Signed-off-by: Matt Hess <[email protected]>

hapi/hedera-protobufs/platform/state/tss/tss_message_map_key.proto

hapi/hedera-protobufs/services/auxiliary/tss/tss_vote.proto

hapi/hedera-protobufs/platform/state/tss/tss_vote_map_key.proto

jsync-swirlds

We still appear to have some confusion regarding the style guidelines for specification. Please consider commenting on the associated PR with suggested clarification to help make the guidelines easier to follow.

hapi/hedera-protobufs/platform/state/tss/tss_message_map_key.proto

hapi/hedera-protobufs/platform/state/tss/tss_vote_map_key.proto

hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto

hapi/hedera-protobufs/services/auxiliary/tss/tss_vote.proto

hapi/hedera-protobufs/services/state/roster/ledger_id.proto

Signed-off-by: Matt Hess <[email protected]>

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

Signed-off-by: Thomas Moran <[email protected]>

thomas-swirlds-labs

LGTM. tyvm! @mhess-swl

jsync-swirlds

Much improved. Just a couple indentation issues.

hapi/hedera-protobufs/services/state/tss/tss_vote_map_key.proto

hapi/hedera-protobufs/services/state/tss/tss_message_map_key.proto

hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

…roto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto

hapi/hedera-protobufs/services/state/roster/ledger_id.proto

lukelee-sl

LGTM

thomas-swirlds-labs

LGTM

mhess-swl added 3 commits October 2, 2024 16:48

TSS Proto Comments: keywords and copyright corrections

798ac83

Signed-off-by: Matt Hess <[email protected]>

Restore tss protos to correct packages

4c18dfc

Signed-off-by: Matt Hess <[email protected]>

Merge branch 'develop' into tss-protobufs

4319f96

mhess-swl requested a review from a team October 3, 2024 00:23

mhess-swl requested review from a team as code owners October 3, 2024 00:23

mhess-swl requested review from jasperpotts, derektriley, lpetrovic05, imalygin and mxtartaglia-sl October 3, 2024 00:23

mhess-swl mentioned this pull request Oct 3, 2024

Adding ledger_id, tssMessage and tssVote related protobufs hashgraph/hedera-protobufs#418

Merged

7 tasks

mhess-swl closed this Oct 3, 2024

mhess-swl reopened this Oct 3, 2024

mhess-swl assigned mhess-swl and thomas-swirlds-labs Oct 3, 2024

mhess-swl added this to the v0.56 milestone Oct 3, 2024

Fix proto compilation

11555a6

Signed-off-by: Matt Hess <[email protected]>

lpetrovic05 reviewed Oct 3, 2024

View reviewed changes

hapi/hedera-protobufs/platform/event/tss_message_transaction.proto Outdated Show resolved Hide resolved

jsync-swirlds previously approved these changes Oct 3, 2024

View reviewed changes

edward-swirldslabs requested changes Oct 4, 2024

View reviewed changes

mhess-swl added 3 commits October 4, 2024 16:21

Designate TSS transactions as services auxiliary

2e71218

Signed-off-by: Matt Hess <[email protected]>

fixes

a5476e4

Signed-off-by: Matt Hess <[email protected]>

Merge remote-tracking branch 'origin/tss-protobufs' into tss-protobufs

5281b7a

thomas-swirlds-labs dismissed their stale review via 5281b7a October 7, 2024 14:22

edward-swirldslabs reviewed Oct 7, 2024

View reviewed changes

jsync-swirlds reviewed Oct 7, 2024

View reviewed changes

mhess-swl and others added 5 commits October 7, 2024 12:55

Another file location fix...

64f5e21

Signed-off-by: Matt Hess <[email protected]>

Update hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto

e8b31f8

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

review comments #2

1028a1c

Signed-off-by: Thomas Moran <[email protected]>

Merge remote-tracking branch 'origin/tss-protobufs' into tss-protobufs

46eed8f

Merge branch 'develop' into tss-protobufs

efb9091

edward-swirldslabs previously approved these changes Oct 8, 2024

View reviewed changes

thomas-swirlds-labs previously approved these changes Oct 8, 2024

View reviewed changes

jsync-swirlds previously approved these changes Oct 8, 2024

View reviewed changes

Update hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto

0a90fe5

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

thomas-swirlds-labs dismissed stale reviews from jsync-swirlds, edward-swirldslabs, and themself via 0a90fe5 October 8, 2024 15:56

thomas-swirlds-labs and others added 2 commits October 8, 2024 16:56

Update hapi/hedera-protobufs/services/state/tss/tss_message_map_key.p…

5691af3

…roto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

Update hapi/hedera-protobufs/services/state/tss/tss_vote_map_key.proto

64c7348

Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Thomas Moran <[email protected]>

jsync-swirlds approved these changes Oct 8, 2024

View reviewed changes

Nana-EC requested a review from lukelee-sl October 8, 2024 16:28

lukelee-sl reviewed Oct 8, 2024

View reviewed changes

hapi/hedera-protobufs/services/auxiliary/tss/tss_message.proto Show resolved Hide resolved

lukelee-sl reviewed Oct 8, 2024

View reviewed changes

hapi/hedera-protobufs/services/state/roster/ledger_id.proto Show resolved Hide resolved

lukelee-sl approved these changes Oct 8, 2024

View reviewed changes

anthony-swirldslabs approved these changes Oct 8, 2024

View reviewed changes

thomas-swirlds-labs approved these changes Oct 8, 2024

View reviewed changes

Merge branch 'develop' into tss-protobufs

c4306fe

mxtartaglia-sl approved these changes Oct 9, 2024

View reviewed changes

thomas-swirlds-labs merged commit e31afe7 into develop Oct 9, 2024
50 checks passed

thomas-swirlds-labs deleted the tss-protobufs branch October 9, 2024 13:16

thomas-swirlds-labs linked an issue Oct 9, 2024 that may be closed by this pull request

Create TSS related system transaction and state protobufs #14744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Correct locations of various TSS protos #15780

chore: Correct locations of various TSS protos #15780

mhess-swl commented Oct 3, 2024

codecov bot commented Oct 3, 2024 •

edited

Loading

codacy-production bot commented Oct 3, 2024 •

edited

Loading

edward-swirldslabs left a comment

jsync-swirlds left a comment

thomas-swirlds-labs left a comment

jsync-swirlds left a comment

lukelee-sl left a comment

thomas-swirlds-labs left a comment

chore: Correct locations of various TSS protos #15780

chore: Correct locations of various TSS protos #15780

Conversation

mhess-swl commented Oct 3, 2024

codecov bot commented Oct 3, 2024 • edited Loading

Codecov Report

codacy-production bot commented Oct 3, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

edward-swirldslabs left a comment

Choose a reason for hiding this comment

jsync-swirlds left a comment

Choose a reason for hiding this comment

thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

jsync-swirlds left a comment

Choose a reason for hiding this comment

lukelee-sl left a comment

Choose a reason for hiding this comment

thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 3, 2024 •

edited

Loading

codacy-production bot commented Oct 3, 2024 •

edited

Loading