remove all k8s services from consul #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxinyi7
added
backport/1.1.x
wangxinyi7
force-pushed
the
xw/NET-10571-de-register-service-command
branch
from
6eea669
to
0c5150d
Compare
jm96441n
reviewed
Aug 16, 2024
jm96441n
reviewed
Aug 16, 2024
jm96441n
reviewed
Aug 16, 2024
jm96441n
reviewed
Aug 16, 2024
charts/consul/templates/sync-catalog-cleanup-k8s-svc-in-consul-job.yaml
Outdated
Show resolved
Hide resolved
wangxinyi7
force-pushed
the
xw/NET-10571-de-register-service-command
branch
from
3c1b2df
to
4c8c7ef
Compare
wangxinyi7
force-pushed
the
xw/NET-10571-de-register-service-command
branch
from
4c8c7ef
to
a211357
Compare
blake
reviewed
Aug 27, 2024
nathancoleman
requested changes
Aug 29, 2024
NiniOak
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
PR looks good to me, well done 💯
I'll wait from an approval from @nathancoleman before merging, as he had some comments earlier
nathancoleman
approved these changes
Aug 30, 2024
This was referenced Aug 30, 2024
wangxinyi7
added a commit
that referenced
this pull request
Sep 3, 2024
wangxinyi7
added a commit
that referenced
this pull request
Sep 3, 2024
wangxinyi7
added a commit
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
consul sync-catalog -purge-k8s-services-from-node=k8s-sync.How I've tested this PR
consul sync-catalog -purge-k8s-services-from-node=k8s-syncHow I expect reviewers to test this PR
Checklist