Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of remove all k8s services from consul into release/1.4.x #4297

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #4255 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@wangxinyi7
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • Support removing the registered K8S services from consul when user runs consul sync-catalog -purge-k8s-services-from-node=k8s-sync.

How I've tested this PR

  1. Start with disabling syncCatalog
  2. Enabling syncCatalog: Confirmed from Consul UI that K8S services registered in Consul
  3. Disabling syncCatalog: registered services still in the dashboard
  4. Run consul sync-catalog -purge-k8s-services-from-node=k8s-sync
  5. Confirmed from Consul UI that registered K8S services are de-registered in Consul

How I expect reviewers to test this PR

Checklist


Overview of commits

Copy link

hashicorp-cla-app bot commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@wangxinyi7 wangxinyi7 marked this pull request as ready for review September 3, 2024 17:10
@wangxinyi7 wangxinyi7 enabled auto-merge (squash) September 3, 2024 17:11
@wangxinyi7 wangxinyi7 force-pushed the backport/xw/NET-10571-de-register-service-command/nicely-saved-kiwi branch from 93e5107 to 6a45d99 Compare September 3, 2024 18:52
@wangxinyi7 wangxinyi7 merged commit 424b917 into release/1.4.x Sep 3, 2024
50 checks passed
@wangxinyi7 wangxinyi7 deleted the backport/xw/NET-10571-de-register-service-command/nicely-saved-kiwi branch September 3, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants