ci: fix CI skip script hole #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, the script will not fail despite SKIP_CHECK_BRANCH being unset, leading to the script explicitly skipping CI when it should fail fast. Prevent this by explicitly checking for the env var. Also fix a small bug where we're incorrectly requiring ',' in the .changelog directory name, which means we'll never skip changelog entries. This change is a port of hashicorp/consul#21741.
zalimeni
added
backport/1.1.x
jm96441n
reviewed
Sep 17, 2024
| @@ -43,7 +44,7 @@ for file_to_check in "${files_to_check_array[@]}"; do | |||
| # - Markdown files | |||
| for dir in "${skipped_directories[@]}"; do | |||
| if [[ "$file_to_check" == */check_skip_ci.sh ]] || | |||
| [[ "$file_to_check" == "$dir"* ]] || | |||
| [[ "$file_to_check" == "$dir/"* ]] || | |||
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, the script will not fail despite
SKIP_CHECK_BRANCHbeing unset, leading to the script explicitly skipping CI when it should fail fast.Prevent this by explicitly checking for the env var.
Also fix a small bug where we're incorrectly requiring ',' in the .changelog directory name, which means we'll never skip changelog entries.
This change is a port of hashicorp/consul#21741.
Testing