Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix CI skip script hole #4323

Merged
merged 1 commit into from
Sep 17, 2024
Merged

ci: fix CI skip script hole #4323

merged 1 commit into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. ci: fix CI skip script hole 

    In some environments, the script will not fail despite SKIP_CHECK_BRANCH
being unset, leading to the script explicitly skipping CI when it should
fail fast.

Prevent this by explicitly checking for the env var.

Also fix a small bug where we're incorrectly requiring ',' in the
.changelog directory name, which means we'll never skip changelog
entries.

This change is a port of hashicorp/consul#21741.
    @zalimeni
    zalimeni committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5b04560 View commit details
    Browse the repository at this point in the history