Fix bug where webhookconfig would not be updated #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
commented
Nov 3, 2021
| certNotify := &cert.Notify{Source: certSource, Ch: certCh, WebhookConfigName: config.Name, SecretName: config.SecretName, SecretNamespace: config.SecretNamespace} | ||
| notifiers = append(notifiers, certNotify) | ||
| go certNotify.Start(ctx) | ||
| go c.certWatcher(ctx, certCh, c.clientset, c.logger) | ||
| } | ||
|
|
There was a problem hiding this comment.
The issue is on line 203. bundle is always set to the last bundle that came out of ch. Then we wake up every defaultRetryDuration to check things but we're only checking one bundle.
lkysow
force-pushed
the
lkysow/cert-manager-fixes
branch
from
bf96c50
to
577e6a3
Compare
lkysow
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
thisisnotashwin
approved these changes
Nov 4, 2021
kschoche
reviewed
Nov 4, 2021
Fixes an issue where if the webhookconfiguration is updated after the webhook cert manager starts, then it is never reset to the correct configuration until the manager is restarted or the certificate expires. The issue was occurring because in the loop where we check the webhookconfiguration we are only checking the webhookconfiguration of the last updated certificate bundle. If there are multiple webhook configurations then we are only watching a single one at a time since the loop always operates on one bundle. The fix is for each webhook to run its own loop. In addition, the reason this was causing issues is because during a helm upgrade we were resetting the webhookconfiguration's caBundle fields. I've removed the caBundle setting (which already didn't exist in the connect injector's webhook config) so that during a helm upgrade it doesn't overwrite that field.
lkysow
force-pushed
the
lkysow/cert-manager-fixes
branch
from
577e6a3
to
1de9bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if the webhookconfiguration is updated after the
webhook cert manager starts, then it is never reset to the correct
configuration until the manager is restarted or the certificate expires.
The issue was occurring because in the loop where we check the
webhookconfiguration we are only checking the webhookconfiguration of
the last updated certificate bundle. If there are multiple webhook
configurations then we are only watching a single one at a time since
the loop always operates on one bundle.
The fix is for each webhook to run its own loop.
In addition, the reason this was causing issues is because during a helm
upgrade we were resetting the webhookconfiguration's caBundle fields.
I've removed the caBundle setting (which already didn't exist in the
connect injector's webhook config) so that during a helm upgrade it
doesn't overwrite that field.
Fixes #808
How I've tested this PR:
"". Wait a couple seconds. Now get the configs. Only one will have been reset properly. Now do the same with this image (ghcr.io/lkysow/consul-k8s-dev:nov03-3)How I expect reviewers to test this PR:
Checklist: