Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where webhookconfig would not be updated #837

Merged
merged 1 commit into from
Nov 4, 2021

Commits on Nov 4, 2021

  1. Fix bug where webhookconfig would not be updated

    Fixes an issue where if the webhookconfiguration is updated after the
    webhook cert manager starts, then it is never reset to the correct
    configuration until the manager is restarted or the certificate expires.
    
    The issue was occurring because in the loop where we check the
    webhookconfiguration we are only checking the webhookconfiguration of
    the last updated certificate bundle. If there are multiple webhook
    configurations then we are only watching a single one at a time since
    the loop always operates on one bundle.
    
    The fix is for each webhook to run its own loop.
    
    In addition, the reason this was causing issues is because during a helm
    upgrade we were resetting the webhookconfiguration's caBundle fields.
    I've removed the caBundle setting (which already didn't exist in the
    connect injector's webhook config) so that during a helm upgrade it
    doesn't overwrite that field.
    lkysow committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    1de9bca View commit details
    Browse the repository at this point in the history