Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session TTL limits configurable #796

Closed
Amit-PivotalLabs opened this issue Mar 18, 2015 · 4 comments
Closed

Make session TTL limits configurable #796

Amit-PivotalLabs opened this issue Mar 18, 2015 · 4 comments

Comments

@Amit-PivotalLabs
Copy link

We would like to be able to configure the minimum Session TTL rather than have it be hardcoded to 10s (although it could default to 10s if a minimum value isn't explicitly passed in). This would be a command line flag as well as a config file option. Specifically, we have several automated tests where we spin up a local consul cluster and test behaviour around locks being acquired and released, and don't want to have to wait for things to happen on a 10s time scale.

Would you all support a pull request for this feature?

For symmetry the maximum TTL could also be made configurable if that's desirable.

Thanks,
Amit + @ematpl

@armon
Copy link
Member

armon commented Mar 18, 2015

@Amit-PivotalLabs I'd be open to a PR that allowed min/max values to be configurable. I'd avoid adding a CLI flag, since it's a very advanced tuning parameter that most people should not touch.

@Amit-PivotalLabs
Copy link
Author

Okay, so config file settings only?

On Wednesday, March 18, 2015, Armon Dadgar [email protected] wrote:

@Amit-PivotalLabs https://github.com/Amit-PivotalLabs I'd be open to a
PR that allowed min/max values to be configurable. I'd avoid adding a CLI
flag, since it's a very advanced tuning parameter that most people should
not touch.


Reply to this email directly or view it on GitHub
#796 (comment).

@armon
Copy link
Member

armon commented Mar 19, 2015

@Amit-PivotalLabs Yep!

@ryanuber
Copy link
Member

Fixed by #821.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants