Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SesionTTLMin configuration #821

Merged
merged 1 commit into from
Mar 27, 2015

Conversation

fraenkel
Copy link

  • Allow setting SessionTTLMin
  • Validate on the Server

@fraenkel
Copy link
Author

Solves #796

@ryanuber
Copy link
Member

This looks great! Thanks for tackling this. We just need another test for the config merging, and some supporting documentation, and with that I think we'll be ready to merge. Feel free to add that, or let me know and I'll be happy to wrap this up as well.

- Allow setting SessionTTLMin
- Validate on the Server
@fraenkel
Copy link
Author

Updated with MergConfig support.

I will let you handle the supporting documentation. I wasn't sure if we wanted to go further and allow tweaking the Max and Multiplier but now at least we know all the spots if and when we do.

@ryanuber
Copy link
Member

Thanks!

ryanuber added a commit that referenced this pull request Mar 27, 2015
Support SesionTTLMin configuration
@ryanuber ryanuber merged commit cf668ab into hashicorp:master Mar 27, 2015
duckhan pushed a commit to duckhan/consul that referenced this pull request Oct 24, 2021
* Add support for metrics to gateways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants