Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shw Grid - Convert components to gts (HDS-3833) #2492

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Shw Grid - Convert components to gts (HDS-3833) #2492

merged 3 commits into from
Oct 14, 2024

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Oct 10, 2024 •
edited
Loading

📌 Summary

If merged, this PR will convert the ShwGrid Showcase components to GTS format.

🔗 External links

👀 Component checklist

  • Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 14, 2024 3:35pm
hds-website ✅ Ready (Inspect) Visit Preview Oct 14, 2024 3:35pm

@KristinLBradley KristinLBradley marked this pull request as ready for review October 10, 2024 22:40
@KristinLBradley KristinLBradley requested review from aklkv and a team October 10, 2024 22:41
didoo
didoo reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of suggestions

showcase/app/components/shw/grid/item.gts Outdated Show resolved Hide resolved
showcase/app/components/shw/grid/item.gts Outdated Show resolved Hide resolved
showcase/app/components/shw/grid/index.gts Outdated Show resolved Hide resolved
@didoo
Copy link
Contributor

didoo commented Oct 11, 2024

@KristinLBradley forgot to mention: you have also to update the import in the template-registry.ts file to include index in the file name, or yarn run lint:hbs would fail; see how it's done for example here:
6c5f080

@KristinLBradley
Copy link
Contributor Author

@KristinLBradley forgot to mention: you have also to update the import in the template-registry.ts file to include index in the file name, or yarn run lint:hbs would fail; see how it's done for example here: 6c5f080

Added & pushed up, thanks. I tried running the linter though and wasn't seeing any errors?

didoo
didoo approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@didoo didoo mentioned this pull request Oct 14, 2024
Merged
1 task
@KristinLBradley KristinLBradley merged commit 4030b10 into main Oct 14, 2024
14 checks passed
@KristinLBradley KristinLBradley deleted the hds-3833-shw-grid-gts-conversion branch October 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo approved these changes

@aklkv aklkv aklkv approved these changes

Assignees
No one assigned
Labels
showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KristinLBradley @didoo @aklkv @hashibot-hds