Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase - Remove leftover Component in Shw::** components class names #2504

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Oct 14, 2024

📌 Summary

While reviewing #2492 I noticed that Kristin (rightly) removed the Component suffix in the component class name. I checked and there are few instances where I forgot to remove it as well.

This small PR cleanups these few leftovers.


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team October 14, 2024 14:23
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 14, 2024 2:25pm
hds-website ✅ Ready (Inspect) Visit Preview Oct 14, 2024 2:25pm

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@didoo didoo merged commit 20f12c1 into main Oct 14, 2024
14 checks passed
@didoo didoo deleted the showcase-gts/component-extends-component branch October 14, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants