Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_autoscaling_lifecycle_hook: Add plan time validation for aws_autoscaling_lifecycle_hook #12145

Merged
merged 8 commits into from
Nov 6, 2023
Merged

r/aws_autoscaling_lifecycle_hook: Add plan time validation for aws_autoscaling_lifecycle_hook #12145

merged 8 commits into from
Nov 6, 2023

Commits on Aug 22, 2020

  1. Add validation functions to autoscaling lifecycle hook arguments 

    Reference for validation patterns: https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LifecycleHook.html
    @jphuynh
    jphuynh committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    5e80237 View commit details
    Browse the repository at this point in the history

  2. Add heartbeat_timeout validation function in autoscaling lifecycle hook 

    Noticed that when trying to set a value lower than 30 seconds and got rejected at during `terraform apply`. Adding that to nicely fail during `terraform plan` when that happens.

This is not documented in [ec2/APIReference/API_LifecycleHook](https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LifecycleHook.html) but can be found in the [Autoscaling user guide](https://github.com/awsdocs/amazon-ec2-auto-scaling-user-guide/blob/master/doc_source/lifecycle-hooks.md#add-lifecycle-hooks-console)
    @jphuynh
    jphuynh committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    33b9cc4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Revert "Add heartbeat_timeout validation function in autoscaling life… 

    …cycle hook"

This reverts commit 33b9cc4.
    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c12666f View commit details
    Browse the repository at this point in the history

  2. Revert "Add validation functions to autoscaling lifecycle hook argume… 

    …nts"

This reverts commit 5e80237.
    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1c774ea View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into HEAD

    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    044fb31 View commit details
    Browse the repository at this point in the history

  4. r/aws_autoscaling_group: Add plan-time validations to 'initial_lifecy… 

    …cle_hook'.
    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8c2113e View commit details
    Browse the repository at this point in the history

  5. r/aws_autoscaling_lifecycle_hook: Add plan-time validation.

    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f46d9b8 View commit details
    Browse the repository at this point in the history

  6. Add CHANGELOG entries.

    @ewbankkit
    ewbankkit committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    30f97ce View commit details
    Browse the repository at this point in the history