-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RabbitMQ 3.13 and ActiveMQ 5.18 Version Mismatch #39024
Merged
jar-b
merged 17 commits into
hashicorp:main
from
architec:b-mq-simplified-version-auto-minor-version-upgrade
Sep 13, 2024
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
73fcefe
fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…
architec 635d825
fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…
architec 3e775e7
fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…
architec 4038f6c
Merge branch 'main' into b-mq-simplified-version-auto-minor-version-u…
jar-b 8331fda
chore: make testacc-lint-fix
jar-b 9501238
r/aws_mq_broker: fix import lints
jar-b 73df9e2
r/aws_mq_broker(test): tidy normalized engine version tests
jar-b 16b4fb5
r/aws_mq_broker(test): fix test config name
jar-b 51e25a3
r/aws_mq_broker: adjust normalization function args, unit test
jar-b 391e82f
r/aws_mq_broker(test): parallel unit test lint
jar-b 567daf6
r/aws_mq_broker: compare engine versions with greater or equal
jar-b ca45ed9
chore: changelog
jar-b 01ab5f8
r/aws_mq_broker: tidy normalizeEngineVersion
jar-b d9c4feb
Merge branch 'main' into b-mq-simplified-version-auto-minor-version-u…
jar-b b189df9
chore: make clean-tidy
jar-b 7ce1385
r/aws_mq_broker: fix engine_version update logic
jar-b cda3a9f
chore: make fix-constants
jar-b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @architec as I was looking at this issue as well. With this setup don't we have to update the code when AWS releases a new version? Also I was looking at how the RDS service had it working and setting up an
actual_engine_version
attribute?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this PR will necessitate code updates when Amazon MQ releases new versions. However, I can submit a subsequent pull request to modify the change, making it applicable to all versions >= 3.13 for RabbitMQ and versions >= 5.18 for ActiveMQ.
With the subsequent PR, adding an attribute such as
actual_engine_version
is unnecessary.