-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming Breaking Changes to Front Door / CDN's #11231
Comments
hey @sebader Thanks for opening this issue. Unfortunately given the extremely short notice from the API team here and the inability to test this before it happens, to be honest it's hard for us to confirm the changes we're going to need to make to Terraform to handle this until after the breaking behavioural change in the API exists (since they may need to change, as happened with the Key Vault Soft Delete changes over Christmas/New Years). Whilst we appreciate the heads up here (and have been tracking this ourselves. I'll pin this issue so others can find it) - as mentioned above I don't think we're going to be able to work around this before it happens, but it's likely this is going to necessitate a couple of breaking changes to both FrontDoor and (potentially) the CDN resources - once that happens (presumably Friday PST) we'll take a look into working around it. @JeffreyRichter is there a reason this breaking change is being made on a Friday to an existing API version with several days notice, rather than in a new API version with a proper deprecation period? Thanks! |
thanks Tom! yeah I figured as well that it will be hard to assess actual impact before the change is implemented but I thought raising this here in advance can't hurt :) |
…0-04-09 More details are in #11231, although it's hard for us to do much about this ahead of time unfortunately due to the inability to test these changes (and confirm which breaking changes are necessary), as such giving some notice this is happening is the most helpful thing we can do at the moment.
…1-04-09 (#11237) More details are in #11231, although it's hard for us to do much about this ahead of time unfortunately due to the inability to test these changes (and confirm which breaking changes are necessary), as such giving some notice this is happening is the most helpful thing we can do at the moment.
This is the first I'm hearing of the breaking change - thanks for bring it to my attention. |
…1-04-09 (hashicorp#11237) More details are in hashicorp#11231, although it's hard for us to do much about this ahead of time unfortunately due to the inability to test these changes (and confirm which breaking changes are necessary), as such giving some notice this is happening is the most helpful thing we can do at the moment.
Ok, first result of my investigation: You can disable the behavior on a subscription level by registering the feature flag:
Register like this
Not saying that this is a solution but maybe at least a workaround |
@sebader thank you for that! I don't know how did you found this but it works. |
Hello! PS: I use modules and terragrunt for deploying my infra. CDN and DNS modules are separated and therefore the execution proceed in two different moments, causing the issue below because of the latest change of microsoft! I think that this issue is related mostly to azurerm provider because it is not allowing me to delete CDN endpoints IF that endpoint has one or more DNS records connected. Before, i was able to delete CDN endpoints without deleting DNS records, so after the module about CDN Endpoints completes, my DNS records module starts. There are two workarounds for now:
So below you can find the error i was getting while i was trying to destroy JUST the
|
@sebader this only appears to cover front door? is there another feature for CDN? |
closing as internally discussed @WodansSon |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Description
A few days ago I got his mail from Azure:
I see a potential issue that could affect the terraform provider with the snippet below that I have been using so far (see below)
New or Affected Resource(s)
Potential Terraform Configuration
This will obviously create a dependency graph from FrontDoor on the CNAME when you create the resources. But destroy would usually work the other way round - which will probably break things with the newly announced behavior.
I have no idea about potential workarounds but thought it's a good idea to at least raise awareness.
The text was updated successfully, but these errors were encountered: