Update azurerm_machine_learning_workspace - deprecate the enterprise sku because it has been deprecated by Azure

[ArcturusZhang]

Fixes #9987

Deprecation note: https://docs.microsoft.com/en-us/azure/machine-learning/concept-workspace#what-happened-to-enterprise-edition

[tombuildsstuff]

@ArcturusZhang based on the deprecation notice

As of September 2020, all capabilities that were available in Enterprise edition workspaces are now also available in Basic edition workspaces. New Enterprise workspaces can no longer be created. Any SDK, CLI, or Azure Resource Manager calls that use the sku parameter will continue to work but a Basic workspace will be provisioned.

and

Beginning December 21st, all Enterprise Edition workspaces will be automatically set to Basic Edition, which has the same capabilities. No downtime will occur during this process. On January 1, 2021, Enterprise Edition will be formally retired.

We may as well deprecate this field entirely and hard-code the value in the create to "Basic" for now?

[ArcturusZhang]

@ArcturusZhang based on the deprecation notice

As of September 2020, all capabilities that were available in Enterprise edition workspaces are now also available in Basic edition workspaces. New Enterprise workspaces can no longer be created. Any SDK, CLI, or Azure Resource Manager calls that use the sku parameter will continue to work but a Basic workspace will be provisioned.

and

Beginning December 21st, all Enterprise Edition workspaces will be automatically set to Basic Edition, which has the same capabilities. No downtime will occur during this process. On January 1, 2021, Enterprise Edition will be formally retired.

We may as well deprecate this field entirely and hard-code the value in the create to "Basic" for now?

I agree that we could hard code this value to Basic. But I am not sure whether new values will be introduced to this attribute in the future. Or we could just remove the deprecation note on it and bring it back when this happens?

[katbyte]

Running tests i see these failing:

TestAccMachineLearningWorkspaceDataSource_basic
--
TestAccMachineLearningWorkspace_basicUpdate
TestAccMachineLearningWorkspace_complete
TestAccMachineLearningWorkspace_requiresImport
TestAccMachineLearningWorkspace_completeUpdate

example error

------- Stdout: -------
=== RUN   TestAccMachineLearningWorkspace_basicUpdate
=== PAUSE TestAccMachineLearningWorkspace_basicUpdate
=== CONT  TestAccMachineLearningWorkspace_basicUpdate
    testing.go:620: Step 1/4 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_key_vault.test will be updated in-place
          ~ resource "azurerm_key_vault" "test" {
                id                              = "/subscriptions/*******/resourceGroups/acctestRG-ml-210325022554324555/providers/Microsoft.KeyVault/vaults/acctestvault210325022555"
                name                            = "acctestvault210325022555"
              - purge_protection_enabled        = true -> null
                tags                            = {}
                # (12 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccMachineLearningWorkspace_basicUpdate (383.33s)
FAIL

------- Stderr: -------
2021/03/25 02:25:53 [DEBUG] not using binary driver name, it's no longer needed
2021/03/25 02:25:54 [DEBUG] not using binary driver name, it's no longer needed```

[katbyte]

Thanks @ArcturusZhang - this LGTM 👍

[ghost]

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!