Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/role_definition: fixing a crash when permissions is nil & making permissions optional #9850

Merged
merged 11 commits into from
Mar 25, 2021
Merged

r/role_definition: fixing a crash when permissions is nil & making permissions optional #9850

merged 11 commits into from
Mar 25, 2021

Commits on Mar 25, 2021

  1. r/role_definition: making the permissions block optional 

    The API returns an empty list if an empty permissions block is sent
but also allows sending an empty list - so it appears that this isn't
required.
    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0274087 View commit details
    Browse the repository at this point in the history

  2. r/role_definition: fixing a crash when expanding permissions block 

    Fixes #9815
    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0810cf0 View commit details
    Browse the repository at this point in the history

  3. r/role_definition: documenting that the permissions block is now op… 

    …tional
    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7c9c595 View commit details
    Browse the repository at this point in the history

  4. r/role_definition: splitting out the Update and polling until it's se… 

    …ttled down

Turns out the Update call is eventually consistent - where a new Role Definition
gets created and then reconciled on the backend. This new Role Definition has a
new CreatedOn and UpdatedOn, so it's possible to determine when this has been
updated - however in testing it can take ~5m for this to settle down.

Whilst it's unfortunate this takes a little longer to settle down, this should
improve the reliability of resources which depend on this.

Unfortunately the Azure SDK doesn't expose these fields in the response, so for
now we're using a wrapped to access them and confirm this has been updated.
    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2b5ba6e View commit details
    Browse the repository at this point in the history

  5. r/role_definition: fixes #3732

    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    66186fc View commit details
    Browse the repository at this point in the history

  6. r/role_definition: tests to private so these are run in sequence

    @tombuildsstuff @jackofallops
    tombuildsstuff authored and jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    89833a2 View commit details
    Browse the repository at this point in the history

  7. update custompoller for time comparison

    @jackofallops
    jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    308f48f View commit details
    Browse the repository at this point in the history

  8. missed some test renames

    @jackofallops
    jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    bd35227 View commit details
    Browse the repository at this point in the history

  9. add error handling to time parse

    @jackofallops
    jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8a90f8c View commit details
    Browse the repository at this point in the history

  10. increase timeout and confirmations for consistency checking

    @jackofallops
    jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    591026b View commit details
    Browse the repository at this point in the history

  11. go mod vendor

    @jackofallops
    jackofallops committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    df97147 View commit details
    Browse the repository at this point in the history