-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/role_definition: fixing a crash when permissions
is nil & making permissions optional
#9850
Merged
Commits on Mar 25, 2021
-
r/role_definition: making the
permissions
block optionalThe API returns an empty list if an empty permissions block is sent but also allows sending an empty list - so it appears that this isn't required.
Configuration menu - View commit details
-
Copy full SHA for 0274087 - Browse repository at this point
Copy the full SHA 0274087View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0810cf0 - Browse repository at this point
Copy the full SHA 0810cf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c9c595 - Browse repository at this point
Copy the full SHA 7c9c595View commit details -
r/role_definition: splitting out the Update and polling until it's se…
…ttled down Turns out the Update call is eventually consistent - where a new Role Definition gets created and then reconciled on the backend. This new Role Definition has a new CreatedOn and UpdatedOn, so it's possible to determine when this has been updated - however in testing it can take ~5m for this to settle down. Whilst it's unfortunate this takes a little longer to settle down, this should improve the reliability of resources which depend on this. Unfortunately the Azure SDK doesn't expose these fields in the response, so for now we're using a wrapped to access them and confirm this has been updated.
Configuration menu - View commit details
-
Copy full SHA for 2b5ba6e - Browse repository at this point
Copy the full SHA 2b5ba6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66186fc - Browse repository at this point
Copy the full SHA 66186fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89833a2 - Browse repository at this point
Copy the full SHA 89833a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 308f48f - Browse repository at this point
Copy the full SHA 308f48fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd35227 - Browse repository at this point
Copy the full SHA bd35227View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a90f8c - Browse repository at this point
Copy the full SHA 8a90f8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 591026b - Browse repository at this point
Copy the full SHA 591026bView commit details -
Configuration menu - View commit details
-
Copy full SHA for df97147 - Browse repository at this point
Copy the full SHA df97147View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.