Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added abandon policy #6830

Conversation

modular-magician
Copy link
Collaborator

Resolved hashicorp/terraform-provider-google#16275

Release Note Template for Downstream PRs (will be copied)

service: added field `deletion_policy` to `google_service_networking_connection`

Derived from GoogleCloudPlatform/magic-modules#9765

* Added abandon policy

* Fixed linting errors on line 68 and 262

* added test coverage

* Fixed test case to pass if network is destroyed successfully

* Disabled testing for state import. Deletion policy isn't an API attribute so it will never import.

* Added documentation for the additional argument
[upstream:76d03c3ad1652dc12fb5f738a907719aa01e0d8e]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit d9422e5 into hashicorp:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_service_networking_connection destroy calls appear to always fail in 5.x despite guidance
1 participant