Added abandon policy

[mike-callahan]

Resolved hashicorp/terraform-provider-google#16275

Release Note Template for Downstream PRs (will be copied)

service: added field `deletion_policy` to `google_service_networking_connection`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 13 insertions(+))
Terraform Beta: Diff ( 1 file changed, 13 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_service_networking_connection (52 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_service_networking_connection" "primary" {
  deletion_policy = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4
Passed tests 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• servicenetworking

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Tests analytics

Total tests: 5
Passed tests 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• servicenetworking

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceNetworkingConnection_abandon

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccServiceNetworkingConnection_abandon[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 101 insertions(+))
Terraform Beta: Diff ( 2 files changed, 101 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 101 insertions(+))
Terraform Beta: Diff ( 2 files changed, 101 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5
Passed tests 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• servicenetworking

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceNetworkingConnection_abandon

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 103 insertions(+))
Terraform Beta: Diff ( 3 files changed, 103 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5
Passed tests 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• servicenetworking

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log