Add support for configuring disk resource policies for google_compute_instance_template

[chrisboulton]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Today, if managing disks with the google_compute_disk resource, you're able to set and manage resource policies (for things like scheduled snapshots, etc) on disks. When using instance templates (google_compute_instance_template) for example with a MIG, there is no ability to set the resource policies that should be attached to a disk when creating the template (consider stateful MIGs, where this would be incredibly helpful)

In the same way that you can attach resource policies to the disk resource, it would be great to be able to do the same with instance templates.

instanceTemplates.insert does seem to have support for this (properties.disks[].initializeParams.resourcePolicies[]), so it "should" just be a matter of surfacing the functionality in Terraform.

New or Affected Resource(s)

• google_compute_instance_template

Potential Terraform Configuration

resource "google_compute_instance_template" "template" {
  ..
  disk {
    source_image = ..
    resource_policies = [
      # similar to google_compute_disk, resource policy uris
    ]
  }
}

References

• Placement Policy for Instance Template #5863 - discusses adding support for instance level resource policies (such as a placement policy) to the instance template, but does not specifically raise support for them on disks.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!