Add support for configuring disk resource policies for google_compute_instance_template.

[rayward]

Fixes #6719

Per documentation (and checked), https://pkg.go.dev/google.golang.org/api/compute/v0.beta#AttachedDiskInitializeParams only the resource policy name is supported for instance templates, a uri can't be used. A link can be used in user code, but it will be converted to the resource name.

[ScottSuarez]

/gcbrun

[ScottSuarez]

can you add this field to the documentation? Possibly an example there-in too?

[rayward]

@ScottSuarez I'm second guessing the decision to support self links on this field when the underlying API doesn't. Do you think I should keep this behaviour (of converting a link) or make it short names only, it's easy enough for a user to reference the name:

resource_policies = [google_compute_resource_policy.my_snapshot_schedule.name]

The source field for disks also doesn't support self-links for example - https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_template#source

[rayward]

I've (tentatively) documented the field, but will adjust it pending the above question.

[ScottSuarez]

Hi, sorry for the delay on this. I was out of town. I spoke with my team on this and we prefer resources to reference each other by the .id property if possible. Its something we've consistently maintained within the provider.

[rayward]

I spoke with my team on this and we prefer resources to reference each other by the .id property if possible.

I think .id is effectively interchangeable for .self_link from what I can see. In any case the resource itself only supports the short name so I can keep the conversion code in and update the documentation and example to use .id.

[ScottSuarez]

/gcbrun

[ScottSuarez]

I'll focus on trying to merge this for you today! Sorry for the delay my friend :>

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!