Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added abandon policy #16944

Conversation

modular-magician
Copy link
Collaborator

Resolved #16275

Release Note Template for Downstream PRs (will be copied)

service: added field `deletion_policy` to `google_service_networking_connection`

Derived from GoogleCloudPlatform/magic-modules#9765

* Added abandon policy

* Fixed linting errors on line 68 and 262

* added test coverage

* Fixed test case to pass if network is destroyed successfully

* Disabled testing for state import. Deletion policy isn't an API attribute so it will never import.

* Added documentation for the additional argument
[upstream:76d03c3ad1652dc12fb5f738a907719aa01e0d8e]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit dc9b041 into hashicorp:main Jan 9, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_service_networking_connection destroy calls appear to always fail in 5.x despite guidance
1 participant