core: Address some issues with ignore_changes

[phinze]

The ignore_changes diff filter was stripping out attributes on Create
but the diff was still making it down to the provider, so Create would
end up missing attributes, causing a full failure if any required
attributes were being ignored.

In addition, any changes that required a replacement of the resource
were causing problems with ignore_chages, which didn't properly filter
out the replacement when the triggering attributes were filtered out.

Refs #5627

[joshuaspence]

Awesome! Looking forward to this.

[phinze]

Noting here that this is insufficient to fix the required attr case - since ChangeType() is unreliable at that point in the execution. Will follow up with more as I dig in further.

[jen20]

This LGTM, but we may want to revisit in future - definitely better than what we have now though!

[phinze]

Discussed with @jen20 - while I'm not sure if this addresses all ignore_changes issues, it does definitely address some of them - enough to warrant including it and moving forward from there.

[tehmaspc]

fixes my current ignore_changes issues; thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.