Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack allow floating ip to target a specific tenant #6454

Merged
merged 1 commit into from
May 25, 2016

Conversation

cristicalin
Copy link
Contributor

Gophercloud library supports specifying a tenant_id in the Create function.

This patch extends the floatingip schema to allow a cloud admin to specify a tenant_id.
Major use cases:

  • Q&A for neutron
  • managed service where the tenants are not allowed to allocate floating IP addresses themselves due to scarcity or resources or organisational security constraints

The patch also adds relevant documentation information.

@cristicalin
Copy link
Contributor Author

The CI failure appears unrelated to this patch, is there a way to trigger the CI job again ?

@jtopjian
Copy link
Contributor

@cristicalin Sorry for the delay on this.

Doing a forceful push will retrigger the Travis checks:

git push -f -u cristicalin neutron_floatingip_tenant_id

If git doesn't want to accept a blank push, something like git commit --amend should make it go.

@cristicalin
Copy link
Contributor Author

cristicalin commented May 19, 2016

Sorry for the late reaction to this.
I pushed again and now its validated cleanly.
I think this in a good state to merge, I did test it out and it's working as expected on a Juno version of openstack.

@cristicalin cristicalin changed the title [WIP] provider/openstack allow floating ip to target a specific tenant provider/openstack allow floating ip to target a specific tenant May 19, 2016
@jtopjian
Copy link
Contributor

LGTM! would it be possible to squash the commits into one? It's good to merge after that. 😄

@cristicalin cristicalin force-pushed the neutron_floatingip_tenant_id branch 2 times, most recently from 7a8f5f7 to cc9a8d5 Compare May 24, 2016 13:26
Allow a cloud admin to target a specific tenant in which to allocate
a floating IP. This is useful when the cloud admin does not want to
delegate network privileges to the tenants or various Q&A scenarios.
@cristicalin cristicalin force-pushed the neutron_floatingip_tenant_id branch from cc9a8d5 to d2b33d5 Compare May 24, 2016 13:31
@cristicalin
Copy link
Contributor Author

squashed and now it should be good to go

@jtopjian
Copy link
Contributor

👍

@jtopjian jtopjian merged commit f3eae84 into hashicorp:master May 25, 2016
@cristicalin cristicalin deleted the neutron_floatingip_tenant_id branch May 25, 2016 11:36
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants