provider/openstack: Implement fixed_ip on floating ip allocations

[carlpett]

When creating ports with multiple fixed addresses, you cannot assign a floating ip to it unless specifying which fixed address to map to. This PR adds functionality for specifying it.

[carlpett]

I added a new required env var to be able to set up a router. That will require some changes in the test environment, I guess?
There might be some room for improvement in the setup of my test case, I had some problems getting a smaller setup to work, but maybe some of the resources can be skipped?

[jtopjian]

@carlpett This is a really nice PR - thanks!

It looks like Travis is failing due to some go fmt issues in the test file. I see some alignment issues with the nested Terraform configuration, too. I run into those all the time, myself...

I'll take a look at this within the next day or so and see if I can find a workaround so the new env variable isn't needed, but if it is, no big deal.

(If you haven't seen it, here's the script that builds out the test environment for acceptance tests.)

[carlpett]

@jtopjian Thanks :)
I had a bunch of issues with the formatting parts of the Makefile, due to working on a Windows machine (CRLF-checkout) and building in the Vagrant environment (expects CR only). I'll try to fix it.

[jtopjian]

@carlpett Just a heads up that #6454 was just merged that edits the same file. There will be some merge conflicts that need resolved for this PR to cleanly merge. Sorry about that...

[carlpett]

@jtopjian No problem :) I've just rebased and updated. Fixed formatting as well, so hopefully the CI will work this time (go fmt is happy, but it looks a bit strange to me...).

[carlpett]

Also, I made a small change - I changed computed to true. I think this is correct, but I could misunderstand how it works?

[jtopjian]

@carlpett This all looks great! Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.