Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: aws_s3_bucket acceleration_status not available in china or us-gov #7999

Merged
merged 1 commit into from
Aug 8, 2016

Commits on Aug 7, 2016

  1. provider/aws: aws_s3_bucket acceleration_status not available in china

    or us-gov
    
    Fixes #7969
    
    `acceleration_status` is not available in China or US-Gov data centers.
    Even querying for this will give the following:
    
    ```
    Error refreshing state: 1 error(s) occurred:
    
    2016/08/04 13:58:52 [DEBUG] plugin: waiting for all plugin processes to
    complete...
    * aws_s3_bucket.registry_cn: UnsupportedArgument: The request contained
    * an unsupported argument.
            status code: 400, request id: F74BA6AA0985B103
    ```
    
    We are going to stop any Read calls for acceleration status from these
    data centers
    
    ```
    % make testacc TEST=./builtin/providers/aws
    % TESTARGS='-run=TestAccAWSS3Bucket_'                                  ✹
    ==> Checking that code complies with gofmt requirements...
    go generate $(go list ./... | grep -v /terraform/vendor/)
    TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSS3Bucket_
    -timeout 120m
    === RUN   TestAccAWSS3Bucket_Notification
    --- PASS: TestAccAWSS3Bucket_Notification (409.46s)
    === RUN   TestAccAWSS3Bucket_NotificationWithoutFilter
    --- PASS: TestAccAWSS3Bucket_NotificationWithoutFilter (166.84s)
    === RUN   TestAccAWSS3Bucket_basic
    --- PASS: TestAccAWSS3Bucket_basic (133.48s)
    === RUN   TestAccAWSS3Bucket_acceleration
    --- PASS: TestAccAWSS3Bucket_acceleration (282.06s)
    === RUN   TestAccAWSS3Bucket_Policy
    --- PASS: TestAccAWSS3Bucket_Policy (332.14s)
    === RUN   TestAccAWSS3Bucket_UpdateAcl
    --- PASS: TestAccAWSS3Bucket_UpdateAcl (225.96s)
    === RUN   TestAccAWSS3Bucket_Website_Simple
    --- PASS: TestAccAWSS3Bucket_Website_Simple (358.15s)
    === RUN   TestAccAWSS3Bucket_WebsiteRedirect
    --- PASS: TestAccAWSS3Bucket_WebsiteRedirect (380.38s)
    === RUN   TestAccAWSS3Bucket_WebsiteRoutingRules
    --- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (258.29s)
    === RUN   TestAccAWSS3Bucket_shouldFailNotFound
    --- PASS: TestAccAWSS3Bucket_shouldFailNotFound (92.24s)
    === RUN   TestAccAWSS3Bucket_Versioning
    --- PASS: TestAccAWSS3Bucket_Versioning (654.19s)
    === RUN   TestAccAWSS3Bucket_Cors
    --- PASS: TestAccAWSS3Bucket_Cors (143.58s)
    === RUN   TestAccAWSS3Bucket_Logging
    --- PASS: TestAccAWSS3Bucket_Logging (249.79s)
    === RUN   TestAccAWSS3Bucket_Lifecycle
    --- PASS: TestAccAWSS3Bucket_Lifecycle (259.87s)
    PASS
    ok      github.com/hashicorp/terraform/builtin/providers/aws
    3946.464s
    ```
    
    thanks to @kwilczynski and @radeksimko for the research on how to handle the generic
    errors here
    
    Running these over a 4G tethering connection has been painful :)
    stack72 committed Aug 7, 2016
    Configuration menu
    Copy the full SHA
    a9f24c9 View commit details
    Browse the repository at this point in the history