Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass nil function when no externalID (this matches old functionality) #27858

Merged
merged 6 commits into from
Jul 26, 2024
Merged

pass nil function when no externalID (this matches old functionality) #27858

merged 6 commits into from
Jul 26, 2024

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Jul 24, 2024

Pass a nil function when the externalID is empty.

This fixes an issue where AWS would reject a blank externalID as too short, presumably because we were passing a non-nil value.

@kpcraig kpcraig requested a review from a team as a code owner July 24, 2024 17:51
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@kpcraig kpcraig added this to the 1.17.3 milestone Jul 24, 2024
@kpcraig kpcraig requested a review from maxcoulombe July 24, 2024 17:58
robmonte
robmonte approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kpcraig kpcraig merged commit 32fdae0 into main Jul 26, 2024
83 checks passed
@kpcraig kpcraig deleted the VAULT-28853/handle-blank-externalID branch July 26, 2024 18:55
Merged
@kpcraig kpcraig modified the milestones: 1.17.3, 1.18.0-rc Aug 14, 2024
@biazmoreira biazmoreira mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmonte robmonte robmonte approved these changes

@maxcoulombe maxcoulombe Awaiting requested review from maxcoulombe

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.18.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@kpcraig @robmonte