Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass nil function when no externalID (this matches old functionality) #27858

Merged
merged 6 commits into from
Jul 26, 2024
Merged

pass nil function when no externalID (this matches old functionality) #27858

merged 6 commits into from
Jul 26, 2024
+11 −1

Commits on Jul 24, 2024

  1. pass nil function when no externalID (this matches old functionality)

    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b9f93ac View commit details
    Browse the repository at this point in the history

  2. omit the function completely when no externalID since it 'feels' more… 

    … obviously correct
    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    88e71c4 View commit details
    Browse the repository at this point in the history

  3. add changelog

    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    afd758f View commit details
    Browse the repository at this point in the history

  4. put the changelog in the right spot

    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    92a864b View commit details
    Browse the repository at this point in the history

  5. fix changelog fix

    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f894512 View commit details
    Browse the repository at this point in the history

  6. fix type in variable name

    @kpcraig
    kpcraig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f7cbaac View commit details
    Browse the repository at this point in the history