Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity info to activity export API #28064

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Aug 13, 2024

Description

RFC: [VLT-324 Enhance Activity Export API with Identity Metadata](https://go.hashi.co/rfc/vlt-324)

This PR expands on #27846 and https://github.com/hashicorp/vault-enterprise/pull/6171 to enhance the activity export API to include identity metadata. The following overall changes are included:

  • VAULT-29101: Add identity metadata fields to json format.
  • VAULT-29102: Add identity metadata fields to csv format. Map and slice fields are flattened into individual columns.
  • No data found within requested start_time and end_time window now results in 204 No Content instead of 400 Bad Request.
  • A new semgrep pattern for the nil-check-physical-storage-by-nsid rule

ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6287

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@ccapurso ccapurso added this to the 1.18.0-rc milestone Aug 13, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 13, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccapurso ccapurso merged commit b003c57 into main Aug 13, 2024
83 checks passed
@ccapurso ccapurso deleted the ccapurso/add-identity-info-to-activity-export branch August 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants