Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-30091: add local alias to activity export output #28138

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Aug 21, 2024

Description

RFC: VLT-324 - Enhance Activity Export API with Identity Metadata

This PR adds expands upon https://github.com/hashicorp/vault-enterprise/pull/6287 and #28064 by adding LocalAlias to ActivityLogExportRecord to denote if an alias is local.

The activity test fixture files have been removed as they are no-longer used in CE tests.

VAULT-30091 - Specify if entity is local in export output
ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6500

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@ccapurso ccapurso added this to the 1.18.0-rc milestone Aug 21, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 21, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good1

@ccapurso ccapurso merged commit b60a7c9 into main Aug 21, 2024
90 checks passed
@ccapurso ccapurso deleted the vault-30091-activity-export-local-alias branch August 21, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants