UI: remove renew self call after login #28204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
approved these changes
Aug 27, 2024
hashishaw
added a commit
that referenced
this pull request
Aug 28, 2024
* check for renewAfterEpoch before comparing it * add test coverage for regression * add comment. Fixes VAULT-4630 * throw error * add changelog
hellobontempo
pushed a commit
that referenced
this pull request
Aug 28, 2024
* check for renewAfterEpoch before comparing it * add test coverage for regression * add comment. Fixes VAULT-4630 * throw error * add changelog
hashishaw
added a commit
that referenced
this pull request
Aug 29, 2024
ryancragun
added a commit
that referenced
this pull request
Aug 29, 2024
ryancragun
added a commit
that referenced
this pull request
Aug 29, 2024
ryancragun
pushed a commit
that referenced
this pull request
Aug 29, 2024
ryancragun
added a commit
that referenced
this pull request
Aug 29, 2024
* backport of commit a5262e0 (#28210) Co-authored-by: Violet Hynes <[email protected]> * UI: remove renew self call after login (#28204) (#28211) * check for renewAfterEpoch before comparing it * add test coverage for regression * add comment. Fixes VAULT-4630 * throw error * add changelog --------- Co-authored-by: Violet Hynes <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When logging in with a non-renewable token (such as root or batch), I was seeing that upon login the UI immediately triggered a
renew-selfcall. I traced it back to this PR where we updated the batch token to also updates expirationTime even though it's not renewable. This causedsetLastFetchto try to compare now to null, which caused it to always renew.Batch token after login before
