Backport of VAULT-30219 CE changes for versioned secret fix into release/1.17.x #28210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
VioletHynes
approved these changes
Aug 28, 2024
|
CI Results: |
|
Build Results: |
VioletHynes
deleted the
backport/violethynes/VAULT-30219-ce/curiously-primary-lamprey
branch
ryancragun
added a commit
that referenced
this pull request
Aug 29, 2024
ryancragun
pushed a commit
that referenced
this pull request
Aug 29, 2024
Co-authored-by: Violet Hynes <[email protected]>
ryancragun
added a commit
that referenced
this pull request
Aug 29, 2024
* backport of commit a5262e0 (#28210) Co-authored-by: Violet Hynes <[email protected]> * UI: remove renew self call after login (#28204) (#28211) * check for renewAfterEpoch before comparing it * add test coverage for regression * add comment. Fixes VAULT-4630 * throw error * add changelog --------- Co-authored-by: Violet Hynes <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #28207 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
Description
CE counterpart for https://github.com/hashicorp/vault-enterprise/pull/6544
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
Overview of commits