Pass command line arguments to hsc2hs using response files #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
reviewed
Aug 29, 2018
Cabal/ChangeLog.md
Outdated
| @@ -94,6 +94,8 @@ | |||
| * Foreign libraries are now linked against the threaded RTS when the | |||
| 'ghc-options: -threaded' flag is used | |||
| ([#5431](https://github.com/haskell/cabal/pull/5431)). | |||
| * Pass command line arguments to `hsc2hs` using response files | |||
There was a problem hiding this comment.
Oh, right. Fixed it :)
hvr
approved these changes
Aug 29, 2018
|
Merged, thanks! |
23Skidoo
added a commit
that referenced
this pull request
Aug 30, 2018
Pass command line arguments to hsc2hs using response files (cherry picked from commit f83aa4a)
|
Also cherry-picked into |
|
Great. Thank you :) |
|
note, this turns out to be incorrect as the version doesn't uniquely determine whether hsc2hs was built w/ support for response files; fix(es) underway |
|
Relevant GHC ticket: https://ghc.haskell.org/trac/ghc/ticket/15758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Fixes #3122. Also see Trac #13896.
hsc2hshas gained the ability to accept command line arguments via response files, which helpsto work around the limit on their length on Windows. This is the next step which updates Cabal to use a response file when invoking
hsc2hs. Unfortunately, I have not yet tried to build the projects (this gist and ermine) mentioned in the issue. I will do it as soon as I get access to a Windows machine (or once I setup Vagrant or something). Note that this patch only changes the invocation logic forhsc2hs >= 0.68.4which will be released with GHC 8.6.re:testing -- I tested this by hand and ensured that the arguments are indeed passed via a response file, and
hsc2hscan successfully process aFoo.hscfile. Also,tests the
hsc2hspre-processor and doesn't fail. I'm not sure if I should add another test./cc @bgamari @RyanGlScott @hvr