Add support to read command line arguments supplied via response files #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks, @ckoparkar! |
hvr
reviewed
Oct 18, 2018
| @@ -74,7 +77,11 @@ main = do | |||
| prog <- getProgramName | |||
| let header = "Usage: "++prog++" [OPTIONS] INPUT.hsc [...]\n" | |||
| usage = usageInfo header options | |||
| #if MIN_VERSION_base(4,12,0) | |||
There was a problem hiding this comment.
This should have risen red flags; as this renders haskell/cabal#5553 incorrect
ping @osa1 @RyanGlScott
There was a problem hiding this comment.
A bug that this (among other things) caused: https://ghc.haskell.org/trac/ghc/ticket/15758
hvr
added a commit
that referenced
this pull request
Oct 18, 2018
…with See also https://ghc.haskell.org/trac/ghc/ticket/15758 The hsc2hs-0.68.4 release was already revised with a lower bound `base >= 4.12` to mitigate the issue solver-side (http://hackage.haskell.org/package/hsc2hs-0.68.4/revisions/) This improves upon #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://ghc.haskell.org/trac/ghc/ticket/13896
/cc @bgamari