Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lsp-1.2 #1631

Merged
merged 9 commits into from
Apr 1, 2021
Merged

Update to lsp-1.2 #1631

merged 9 commits into from
Apr 1, 2021

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Mar 28, 2021

No description provided.

@wz1000
Copy link
Collaborator Author

wz1000 commented Mar 31, 2021

A lot of code action tests are failing because they use incorrect ranges and lsp-test recently became more strict about this: haskell/lsp@f90b002

:( It is a lot of work to fix all of them.

@jneira
Copy link
Member

jneira commented Mar 31, 2021

Maybe we could restore the old function in lsp, make it deprecated and translate tests progressively?

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@wz1000
Copy link
Collaborator Author

wz1000 commented Mar 31, 2021

Benchmarks seem to show some very minor improvements in allocations, possibly because lsp-types started using StrictData.

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Apr 1, 2021
@mergify mergify bot merged commit 6d1f1a5 into master Apr 1, 2021
berberman pushed a commit to berberman/haskell-language-server that referenced this pull request Apr 4, 2021
* Update to lsp-1.2

* fix stack

* fix splice plugin tests

* fix tactic plugin tests

* fix some tests

* fix some tests

* fix outline tests

* hlint

* fix func-test
isovector pushed a commit to isovector/haskell-language-server that referenced this pull request Apr 5, 2021
* Update to lsp-1.2

* fix stack

* fix splice plugin tests

* fix tactic plugin tests

* fix some tests

* fix some tests

* fix outline tests

* hlint

* fix func-test
mergify bot added a commit that referenced this pull request Apr 6, 2021
* Start tracking provenance of stale data

It's amazing how wrong this code used to be

* Add some machinery for automagically updating the age

* Add an applicative instance

* Tracked ages makes everything much easier to reason about

* Formatting

* Haddock and small changes

* Update haddock on IdeAction

* Update to lsp-1.2 (#1631)

* Update to lsp-1.2

* fix stack

* fix splice plugin tests

* fix tactic plugin tests

* fix some tests

* fix some tests

* fix outline tests

* hlint

* fix func-test

* Avoid reordering plugins (#1629)

* Avoid reordering plugins

Order of execution matters for notification plugins, so lets avoid unnecessary
reorderings

* remove duplicate plugins

* fix tests

* Civilized indexing progress reporting (#1633)

* Civilized indexing progress reporting

* optProgressStyle

* Consistency: Indexing references ==> Indexing

* Fix progress tests

* Do not override custom user commands (#1650)

Co-authored-by: Potato Hatsue <[email protected]>

* Shut the Shake session on exit, instead of restarting it (#1655)

Restarting the session will result in progress reporting and other messages
being sent to the client, which might have already closed the stream

Co-authored-by: Potato Hatsue <[email protected]>

* Fix importing type operators (#1644)

* Fix importing type operators

* Update test

* Add expected failure tests

* log exceptions before killing the server (#1651)

* log hiedb exceptions before killing the server

* This is not the hiedb thread - fix message

* Fix handler - either an error or success

* additional .gitignore entries (#1659)

* Fix ignore paths (#1656)

* Skip individual steps

* Skip individual steps

* And needs pre_job

* Add bounds for Diff (#1665)

* Replace Barrier with MVar in lsp main (#1668)

* Port UseStale to ghcide

* Use the new ghcide UseStale machinery

* Fix hlint complaints

Co-authored-by: wz1000 <[email protected]>
Co-authored-by: Pepe Iborra <[email protected]>
Co-authored-by: Potato Hatsue <[email protected]>
Co-authored-by: Javier Neira <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
3 participants