Fix a wingman bug caused by mismanaged stale data #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Apr 3, 2021
isovector
changed the title
* Update to lsp-1.2 * fix stack * fix splice plugin tests * fix tactic plugin tests * fix some tests * fix some tests * fix outline tests * hlint * fix func-test
* Avoid reordering plugins Order of execution matters for notification plugins, so lets avoid unnecessary reorderings * remove duplicate plugins * fix tests
* Civilized indexing progress reporting * optProgressStyle * Consistency: Indexing references ==> Indexing * Fix progress tests
Co-authored-by: Potato Hatsue <[email protected]>
Restarting the session will result in progress reporting and other messages being sent to the client, which might have already closed the stream Co-authored-by: Potato Hatsue <[email protected]>
* Fix importing type operators * Update test * Add expected failure tests
* log hiedb exceptions before killing the server * This is not the hiedb thread - fix message * Fix handler - either an error or success
* Skip individual steps * Skip individual steps * And needs pre_job
isovector
force-pushed
the
no-stale-ranges
branch
from
bb68fed
to
80122ec
Compare
|
This looks like it could be generally useful. @isovector might be worth putting the tracked |
|
@pepeiborra . Done. PTAL, and feel free to mark as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wingman uses a lot of potentially stale rules, and each comes with its own position mapping. But I was stupid when I first wrote this, and didn't realize just because there results were stale didn't mean they refer to the same document.
This PR adds some type-level information, allowing me to track the age of results from Shake. By throwing an untouchable variable inside of the stale tag, the compiler makes sure I haven't accidentally scrambled ranges between different versions of the document.