Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix console ui issues (close #1303) (close #1049) (close #1282) #1330

Merged
merged 1 commit into from
Jan 8, 2019
Merged

fix console ui issues (close #1303) (close #1049) (close #1282) #1330

merged 1 commit into from
Jan 8, 2019

Conversation

surendran82
Copy link
Contributor

@surendran82 surendran82 commented Jan 7, 2019 •
edited by karthikvt26
Loading

Fix and close #1303, #1049 and #1282

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@karthikvt26 karthikvt26 changed the title Fixes #1303, #1049 and #1282 Fix console UI issues Jan 7, 2019
@hasura-bot
Copy link
Contributor

Review app for commit a583a47 deployed to Heroku: https://hge-ci-pull-1330.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1330-a583a47

karthikvt26
karthikvt26 approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthikvt26 karthikvt26 added the s/ok-to-merge Status: This pull request can be merged to master label Jan 7, 2019
@shahidhk shahidhk changed the title Fix console UI issues fix console ui issues (close #1303) (close #1049) (close #1282) Jan 8, 2019
@shahidhk shahidhk added the c/console Related to console label Jan 8, 2019
@shahidhk shahidhk merged commit ca5ccd7 into hasura:master Jan 8, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1330.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Nov 11, 2024
@danieljharvey @hasura-bot
Build: use native target CPU (#1330)
9f28f41 
<!-- The PR description should answer 2 important questions: -->

### What

Have seen this advised in both the [Rust Performance
Book](https://nnethercote.github.io/perf-book/build-configuration.html#cpu-specific-instructions)
and in the [Datafusion
docs](https://datafusion.apache.org/user-guide/crate-configuration.html),
seems like there's no drawbacks and the possibility of extra juice. My
M1 Mac shows a no-op in benchmarks, but since it's going to change
depending on CPU plan to merge and take a look at the CI benchmarks too.

V3_GIT_ORIGIN_REV_ID: 7b5d5668b3a8949dd56b2a887f10d964d523bdd6
hasura-bot pushed a commit that referenced this pull request Nov 12, 2024
@danieljharvey @hasura-bot
Revert "Build: use native target CPU (#1330)" (#1338)
a2353ae 
This reverts commit 7b5d5668b3a8949dd56b2a887f10d964d523bdd6.

<!-- The PR description should answer 2 important questions: -->

### What

Deployed different commits to `staging` and this one broke it, so
rolling it back.

V3_GIT_ORIGIN_REV_ID: ba93bbc61b38d2c756e109e24566f8d51b01d458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikvt26 karthikvt26 karthikvt26 approved these changes

Assignees
No one assigned
Labels
c/console Related to console s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change hasura logo on access key prompt screen
4 participants
@surendran82 @hasura-bot @karthikvt26 @shahidhk