Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually hold on to the test subscriber #444

Closed
wants to merge 1 commit into from
Closed

Actually hold on to the test subscriber #444

wants to merge 1 commit into from

Conversation

jamesmunns
Copy link
Collaborator

No description provided.

@jamesmunns
Copy link
Collaborator Author

@hawkw I dunno if this was intentional for some other reason, but it seems like the "init tracing" helper returned a guard that the caller is supposed to hold, but none (or not all?) of the tests that called it actually held it.

This makes a single return type (because rustc was Big Mad when I used Box<dyn Drop>) based on the features, and marks it as must use.

If you want me to rebase this on main instead of your test branch, lemme know.

@jamesmunns jamesmunns requested a review from hawkw June 18, 2023 13:05
hawkw
hawkw approved these changes Jun 18, 2023
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, my bad — thanks for fixing this. i would prefer to merge the PR into main, and rebase my test PR onto it, if you don't mind?

@jamesmunns jamesmunns mentioned this pull request Jun 18, 2023
Merged
@jamesmunns
Copy link
Collaborator Author

No worries! Replaced by #445.

@jamesmunns jamesmunns closed this Jun 18, 2023
jamesmunns added a commit that referenced this pull request Jun 20, 2023
@jamesmunns
Add a test subscriber guard to properly capture tracing messages (#445)
e6b1fce 
This change allows for capturing (or viewing) of tracing output during timer wheel tests.

Closes #444
hawkw pushed a commit that referenced this pull request Jun 20, 2023
@jamesmunns @hawkw
test(maitake): properly capture tracing messages (#445)
cb0de4e 
The "init tracing" test helper returned a guard that the caller
is supposed to hold, but none (or not all?) of the tests that called it
actually held it.

This makes a single return type (because `rustc` was Big Mad when I used
`Box<dyn Drop>`) based on the features, and marks it as must use.

This change allows for capturing (or viewing) of tracing output during
timer wheel tests.

Closes #444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmunns @hawkw