Add a test subscriber guard to properly capture tracing messages #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Jun 20, 2023
hawkw
pushed a commit
that referenced
this pull request
Jun 20, 2023
The "init tracing" test helper returned a guard that the caller is supposed to hold, but none (or not all?) of the tests that called it actually held it. This makes a single return type (because `rustc` was Big Mad when I used `Box<dyn Drop>`) based on the features, and marks it as must use. This change allows for capturing (or viewing) of tracing output during timer wheel tests. Closes #444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444