Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing labels in RPPD data, cleanup #76

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Apr 12, 2024

(Output of `rppd-to-strapi.flux` is input for the others)

Results in missing URIs in output:

`sbt "runMain rpb.ETL conf/rppd-to-gnd-mapping.flux"`

Errors on running:

`sbt "runMain rpb.ETL conf/rppd-rppdId-with-label-map.flux"`

Missing labels in RPPD test output:

`sbt "runMain rpb.ETL conf/rppd-test-to-lobid.flux"`
Creation of lookup file maps was still based on Allegro field names
For persons both in RPPD and GND, selected from RPPD in Strapi e.g.
http://rppd.lobid.org/118589598 in http://rppd.lobid.org/121384462

Also update and clean up person lookup maps for current usage
@fsteeg fsteeg changed the title Missing labels in RPPD data and UI Fix missing labels in RPPD data, cleanup Apr 15, 2024
@fsteeg fsteeg marked this pull request as ready for review April 15, 2024 14:48
@fsteeg fsteeg requested a review from acka47 April 15, 2024 14:48
@fsteeg
Copy link
Member Author

fsteeg commented Apr 15, 2024

Deployed to test: http://test.rppd.lobid.org/121384462

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 assigned fsteeg and unassigned acka47 Apr 16, 2024
@fsteeg fsteeg merged commit 4763f0d into main Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants