Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing labels in RPPD data, cleanup #76

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Fix missing labels in RPPD data, cleanup #76

merged 7 commits into from
Apr 17, 2024

Commits on Apr 12, 2024

  1. Fix workflow order in script, add actual output (RPB-154) 

    (Output of `rppd-to-strapi.flux` is input for the others)

Results in missing URIs in output:

`sbt "runMain rpb.ETL conf/rppd-to-gnd-mapping.flux"`

Errors on running:

`sbt "runMain rpb.ETL conf/rppd-rppdId-with-label-map.flux"`

Missing labels in RPPD test output:

`sbt "runMain rpb.ETL conf/rppd-test-to-lobid.flux"`
    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e018c2b View commit details
    Browse the repository at this point in the history

  2. Default to using Strapi, not Allegro data (actual production setup)

    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2a59d13 View commit details
    Browse the repository at this point in the history

  3. Update lookup mappings for new human-readable RPPD fields (RPB-154) 

    Creation of lookup file maps was still based on Allegro field names
    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c2ad038 View commit details
    Browse the repository at this point in the history

  4. Fix value_column used for RPPD person label lookup (RPB-154)

    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    392021c View commit details
    Browse the repository at this point in the history

  5. Create lookup file maps from Strapi, not Allegro data (RPB-154)

    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1998c95 View commit details
    Browse the repository at this point in the history

  6. Add RPPD test record with missing labels from Strapi (RPB-154)

    @fsteeg
    fsteeg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c5348c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Fix label lookup for RPPD-URIs with GND identifier (RPB-154) 

    For persons both in RPPD and GND, selected from RPPD in Strapi e.g.
http://rppd.lobid.org/118589598 in http://rppd.lobid.org/121384462

Also update and clean up person lookup maps for current usage
    @fsteeg
    fsteeg committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    61f1be6 View commit details
    Browse the repository at this point in the history