Update CI #8
Merged
Update CI #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update OS and actions/checkout versions
Add CentOS Stream dependencies
hdholm
added a commit
that referenced
this pull request
May 20, 2023
* Update CI (#8) * Update build.yml Update OS and actions/checkout versions * Update install-dependencies Add CentOS Stream dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update build.yml * Update build.yml * Update actions.checkout to v3 Missed that there was a separate invocation for the osx builds. * Remove extraneous spaces * Clean up this messed up pull. CentOS Stream 9 seems to work with clang and since changes would be needed to deal with clang in SCL for CentOS 7 it's pretty clear that never worked although the gcc build seems fine.
hdholm
added a commit
that referenced
this pull request
May 29, 2023
* Update CI (#8) * Update build.yml Update OS and actions/checkout versions * Update install-dependencies Add CentOS Stream dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update build.yml * Update build.yml * Update actions.checkout to v3 Missed that there was a separate invocation for the osx builds. * Remove extraneous spaces * Clean up this messed up pull. CentOS Stream 9 seems to work with clang and since changes would be needed to deal with clang in SCL for CentOS 7 it's pretty clear that never worked although the gcc build seems fine.
hdholm
added a commit
that referenced
this pull request
Jan 23, 2024
* Clean up this messed up pull. CentOS Stream 9 seems to work with clang and since changes would be needed to deal with clang in SCL for CentOS 7 it's pretty clear that never worked although the gcc build seems fine. * Add optional dependencies to ensure everything possible builds. And add "setup" to avoid meson warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates github actions to:
In my initial pass, there were failures for Ubuntu:bionic and, for clang on CentOS 7 and CentOS Stream 9. Rather than spend a lot of time trying to resolve the failures I simply removed the clang attempts for CentOS7 and Stream 9. It's probably some dependency issue if someone wants to chase it. I simply removed Ubuntu:bionic since it's EOL at the end of the month anyway.