Update CI (#8) #129
Update CI (#8) #129
Conversation
* Update build.yml Update OS and actions/checkout versions * Update install-dependencies Add CentOS Stream dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update install-dependencies * Update build.yml * Update build.yml
Missed that there was a separate invocation for the osx builds.
| @@ -15,12 +15,19 @@ jobs: | |||
| os: | |||
| - fedora:latest | |||
| - quay.io/centos/centos:stream8 | |||
| - quay.io/centos/centos:stream9 | |||
There was a problem hiding this comment.
Is this removal necessary?
There was a problem hiding this comment.
It's in the commit message. CentOS 7 and Stream 9 got moved out of the first block (which uses both clang and gcc) and into the block below configured simply for gcc. clang wasn't getting installed correctly on either CentOS 7 nor Stream 9 and although it's probably some rpm/dnf magic I'm overlooking I couldn't figure it out after a little looking so it seemed better to (for the moment at least) just drop the clang compiles to get the CI tests running and hopefully someone can figure out what needs to happen to get clang happy on those two OSs.
There was a problem hiding this comment.
Hello. Thanks for clarifying. I will open an Issue then to track the clang on CentOS Stream 9 issue.
There was a problem hiding this comment.
I'm not sure why clang in Stream 9 was failing (possibly getting wrong install dependencies section) but it works now with the cleaned up version I just pushed. Only CentOS 7 seems to fail with clang and that's because clang is in the SCL in CentOS 7 and would require changes to the build to run the compiler with the SCL command. Since it's clearly never worked before and the gcc build works fine and CentOS 7 is approaching EOL, it doesn't seem worth the work to make the changes necessary for clang rather than just live with gcc there.
There was a problem hiding this comment.
Hello @hdholm. Thanks for the PR. I agree it is not that important to have clang compilation in CentOS7 right now.
In my opinion, this can be merged.
Let's wait a little bit for @sergio-correia to have a view on it and we will merge it before creating the new release.
…g and since changes would be needed to deal with clang in SCL for CentOS 7 it's pretty clear that never worked although the gcc build seems fine.
…dd "setup" to avoid meson warning.
|
Change LGTM. @sergio-correia : can you please share your view on this change? |
This updates github actions to:
Include current OS versions
Update actions/checkout to version 3 in advance of the imminent NodeJS deprecation
Add dependency installation for CentOS Stream versions
In my initial pass, there were failures for Ubuntu:bionic and, for clang on CentOS 7 and CentOS Stream 9. Rather than spend a lot of time trying to resolve the failures I simply removed the clang attempts for CentOS7 and Stream 9. It's probably some dependency issue if someone wants to chase it. I simply removed Ubuntu:bionic since it's EOL at the end of the month anyway.