Add test_gallery.py and debug python_3.7 gallery tests (#53)

* first * Debug * Revert "Debug" This reverts commit 3d48d08. * Remove test code changing current dir from the tutorial * Update tox.ini * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update test_gallery.py * Update test_gallery.py * Update test_gallery.py * test_gallery * test_gallery * test_gallery * test_gallery * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update requirements-doc.txt * Update CHANGELOG.md * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update setup.py * Update plot_nwb_zarrio.py * Update plot_nwb_zarrio.py * Update plot_convert_nwb_hdf5.py * Update plot_zarr_io.py * Update plot_zarr_dataset_io.py * Update plot_nwb_zarrio.py * Update plot_zarr_dataset_io.py * Update plot_convert_nwb_hdf5.py * Use local copy of NWB file to avoid use of special characters in folder names (#61) * Fix #60 Use local copy of NWB file to avoid use of special characters in folder names * Remove DANDI as dependency for the docs * Remove extraneous close calls for io objects closed automatically by with contexts * Update test.py and test_gallery.py scripts to set consistent working directory for scripts * Updated changelog Co-authored-by: rly <[email protected]> Co-authored-by: Oliver Ruebel <[email protected]> Co-authored-by: Oliver Ruebel <[email protected]>
hdmf-dev · Jan 4, 2023 · e685e7d · e685e7d
1 parent e3d063a
commit e685e7d
Show file tree

Hide file tree

Showing 14 changed files with 253 additions and 52 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,17 +3,29 @@
 ## 0.1.7 (Upcoming)
 
 ### Bugs
-* Use path relative to the current Zarr file in the definition of links and references to avoid breaking
-  links when moving Zarr files @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
-* Fix bugs in requirements defined in setup.py @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
-* Update dateset used in conversion tutorial, which caused warnings  @oruebel [#56](https://github.com/hdmf-dev/hdmf-zarr/pull/56)
+* Updated the storage of links/references to use paths relative to the current Zarr file to avoid breaking
+  links/reference when moving Zarr files @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
+* Fixed bugs in requirements defined in setup.py @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
+* Fixed bug regarding Sphinx external links @mavaylon1 [#53](https://github.com/hdmf-dev/hdmf-zarr/pull/53)
+* Updated gallery tests to use test_gallery.py and necessary package dependcies 
+  @mavaylon1 [#53](https://github.com/hdmf-dev/hdmf-zarr/pull/53)
+* Updated dateset used in conversion tutorial, which caused warnings 
+  @oruebel [#56](https://github.com/hdmf-dev/hdmf-zarr/pull/56)
 
 ### Docs
-* Add tutorial illustrating how to create a new NWB file with NWBZarrIO @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
-* Add docs for describing the mapping of HDMF schema to Zarr storage @oruebel [#48](https://github.com/hdmf-dev/hdmf-zarr/pull/48)
+* Added tutorial illustrating how to create a new NWB file with NWBZarrIO 
+  @oruebel [#46](https://github.com/hdmf-dev/hdmf-zarr/pull/46)
+* Added docs for describing the mapping of HDMF schema to Zarr storage 
+  @oruebel [#48](https://github.com/hdmf-dev/hdmf-zarr/pull/48)
+* Added ``docs/gallery/resources`` for storing local files used by the tutorial galleries 
+  @oruebel [#61](https://github.com/hdmf-dev/hdmf-zarr/pull/61)
+* Removed dependency on ``dandi`` library for data download in the conversion tutorial by storing the NWB files as 
+  local resources @oruebel [#61](https://github.com/hdmf-dev/hdmf-zarr/pull/61)
 
 ## 0.1.0 
 
 ### New features
 
-- Created new optional Zarr-based I/O backend for writing files using Zarr's `zarr.store.DirectoryStore` backend, including support for iterative write, chunking, compression, simple and compound data types, links, object references, namespace and spec I/O.
+* Created new optional Zarr-based I/O backend for writing files using Zarr's `zarr.store.DirectoryStore` backend, 
+  including support for iterative write, chunking, compression, simple and compound data types, links, object 
+  references, namespace and spec I/O.
diff --git a/docs/gallery/plot_convert_nwb_hdf5.py b/docs/gallery/plot_convert_nwb_hdf5.py
@@ -5,37 +5,45 @@
 This tutorial illustrates how to convert data between HDF5 and Zarr using
 a Neurodata Without Borders (NWB) file from the DANDI data archive as an example.
 In this tutorial we will convert our example file from HDF5 to Zarr and then
-back again to HDF5.
+back again to HDF5. The NWB standard is defined using :hdmf-docs:`HDMF <>` and uses the
+:py:class:`~ hdmf.backends.hdf5.h5tools.HDF5IO`  HDF5 backend from HDMF for storage.
 """
 
 
 ###############################################################################
 # Setup
 # -----
 #
-# We first **download a small NWB file** from the DANDI neurophysiology data archive as an example.
-# The NWB standard is defined using HDMF and uses the :py:class:`~ hdmf.backends.hdf5.h5tools.HDF5IO`
-# HDF5 backend from HDMF for storage.
+# Here we use a small NWB file from the DANDI neurophysiology data archive from
+# `DANDIset 000009 <https://dandiarchive.org/dandiset/000009/0.220126.1903>`_ as an example.
+# To download the file directly from DANDI we can use:
+#
+# .. code-block:: python
+#    :linenos:
+#
+#    from dandi.dandiapi import DandiAPIClient
+#    dandiset_id = "000009"
+#    filepath = "sub-anm00239123/sub-anm00239123_ses-20170627T093549_ecephys+ogen.nwb"   # ~0.5MB file
+#    with DandiAPIClient() as client:
+#        asset = client.get_dandiset(dandiset_id, 'draft').get_asset_by_path(filepath)
+#        s3_path = asset.get_content_url(follow_redirects=1, strip_query=True)
+#        filename = os.path.basename(asset.path)
+#    asset.download(filename)
+#
+# We here use a local copy of a small file from this DANDIset as an example:
+#
 
 # sphinx_gallery_thumbnail_path = 'figures/gallery_thumbnail_plot_convert_nwb.png'
 import os
 import shutil
-from dandi.dandiapi import DandiAPIClient
-
-dandiset_id = "000009"
-filepath = "sub-anm00239123/sub-anm00239123_ses-20170627T093549_ecephys+ogen.nwb"   # ~0.5MB file
-with DandiAPIClient() as client:
-    asset = client.get_dandiset(dandiset_id, 'draft').get_asset_by_path(filepath)
-    s3_path = asset.get_content_url(follow_redirects=1, strip_query=True)
-    filename = os.path.basename(asset.path)
-asset.download(filename)
-
-###############################################################################
-# Next we define the names of the files to generate as part of this tutorial and clean up any
-# data from previous executions of this tutorial.
 
-zarr_filename = "test_zarr_" + filename + ".zarr"
-hdf_filename = "test_hdf5_" + filename
+# Input file to convert
+basedir = "resources"
+filename = os.path.join(basedir, "sub_anm00239123_ses_20170627T093549_ecephys_and_ogen.nwb")
+# Zarr file to generate for converting from HDF5 to Zarr
+zarr_filename = "test_zarr_" + os.path.basename(filename) + ".zarr"
+# HDF5 file to generate for converting from Zarr to HDF5
+hdf_filename = "test_hdf5_" + os.path.basename(filename)
 
 # Delete our converted HDF5 and Zarr file from previous runs of this notebook
 for fname in [zarr_filename, hdf_filename]:
@@ -91,6 +99,7 @@
 # :pynwb-docs:`Trials <tutorials/general/plot_timeintervals.html>` table.
 
 zf.trials.to_dataframe()[['start_time', 'stop_time', 'type', 'photo_stim_type']]
+zr.close()
 
 ###############################################################################
 # Convert the Zarr file back to HDF5

diff --git a/docs/gallery/plot_nwb_zarrio.py b/docs/gallery/plot_nwb_zarrio.py
@@ -135,24 +135,12 @@
 with NWBZarrIO(path=path, mode="w") as io:
     io.write(nwbfile)
 
-###############################################################################
-# Test opening the file
-# ---------------------
-with NWBZarrIO(path=path, mode="r") as io:
-    infile = io.read()
-
 ###############################################################################
 # Test opening with the absolute path instead
 # -------------------------------------------
-with NWBZarrIO(path=absolute_path, mode="r") as io:
-    infile = io.read()
-
-###############################################################################
-# Test changing the current directory
-# ------------------------------------
-
-import os
-os.chdir(os.path.abspath(os.path.join(os.getcwd(), "../")))
-
+#
+# The main reason for using the ``absolute_path`` here is for testing purposes
+# to ensure links and references work as expected. Otherwise, using the
+# relative ``path`` here instead is fine.
 with NWBZarrIO(path=absolute_path, mode="r") as io:
     infile = io.read()
diff --git a/docs/gallery/plot_zarr_dataset_io.py b/docs/gallery/plot_zarr_dataset_io.py
@@ -110,3 +110,7 @@
           (c.name,
            str(c.data.chunks),
            str(c.data.compressor)))
+
+###############################################################################
+#
+zarr_io.close()
diff --git a/docs/gallery/plot_zarr_io.py b/docs/gallery/plot_zarr_io.py
@@ -86,6 +86,9 @@
 intable = zarr_io.read()
 intable.to_dataframe()
 
+###############################################################################
+#
+zarr_io.close()
 
 ###############################################################################
 # Converting to/from HDF5 using ``export``

diff --git a/docs/gallery/resources/README.rst b/docs/gallery/resources/README.rst
@@ -0,0 +1,24 @@
+Resources
+=========
+
+sub_anm00239123_ses_20170627T093549_ecephys_and_ogen.nwb
+--------------------------------------------------------
+
+This NWB file was downloaded from `DANDIset 000009 <https://dandiarchive.org/dandiset/000009/0.220126.1903>`_
+The file was modified to replace ``:`` characters used in the name of the ``ElectrodeGroup`` called ``ADunit: 32`` in
+``'general/extracellular_ephys/`` to ``'ADunit_32'``. The dataset ``general/extracellular_ephys/electrodes/group_name``
+as part of the electrodes table was updated accordingly to list the appropriate group name. This is to avoid issues
+on Windows file systems that do not support ``:`` as part of folder names. The asses can be downloaded from DANDI via:
+
+.. code-block:: python
+    :linenos:
+
+    from dandi.dandiapi import DandiAPIClient
+    dandiset_id = "000009"
+    filepath = "sub-anm00239123/sub-anm00239123_ses-20170627T093549_ecephys+ogen.nwb"   # ~0.5MB file
+    with DandiAPIClient() as client:
+        asset = client.get_dandiset(dandiset_id, 'draft').get_asset_by_path(filepath)
+        s3_path = asset.get_content_url(follow_redirects=1, strip_query=True)
+        filename = os.path.basename(asset.path)
+    asset.download(filename)
+
diff --git a/docs/gallery/resources/sub_anm00239123_ses_20170627T093549_ecephys_and_ogen.nwb b/docs/gallery/resources/sub_anm00239123_ses_20170627T093549_ecephys_and_ogen.nwb
diff --git a/docs/source/conf.py b/docs/source/conf.py
@@ -77,8 +77,8 @@
 intersphinx_mapping = {
     'python': ('https://docs.python.org/3.10', None),
     'numpy': ('https://numpy.org/doc/stable/', None),
-    'scipy': ('https://docs.scipy.org/doc/scipy/reference', None),
-    'matplotlib': ('https://matplotlib.org', None),
+    'scipy': ('https://docs.scipy.org/doc/scipy/', None),
+    'matplotlib': ('https://matplotlib.org/stable/', None),
     'h5py': ('https://docs.h5py.org/en/latest/', None),
     'pandas': ('https://pandas.pydata.org/pandas-docs/stable/', None),
     'hdmf': ('https://hdmf.readthedocs.io/en/stable/', None),

diff --git a/docs/source/overview.rst b/docs/source/overview.rst
@@ -30,3 +30,4 @@ Known Limitations
 - Currently the :py:class:`~hdmf_zarr.backend.ZarrIO` backend uses Zarr's :py:class:`~zarr.storage.DirectoryStore` only. Other `Zarr stores <https://zarr.readthedocs.io/en/stable/api/storage.html>`_ could be added but will require proper treatment of links and references for those backends as links are not supported in Zarr (see `zarr-python issues #389 <https://github.com/zarr-developers/zarr-python/issues/389>`_.
 - Exporting of HDF5 files with external links is not yet fully implemented/tested. (see `hdmf-zarr issue #49 <https://github.com/hdmf-dev/hdmf-zarr/issues/49>`_.
 - Object references are currently always resolved on read (as are links) rather than being loaded lazily (see `hdmf-zarr issue #50 <https://github.com/hdmf-dev/hdmf-zarr/issues/50>`_.
+- Special characters (e.g., ``:``, ``<``, ``>``, ``"``, ``/``, ``\``, ``|``, ``?``, or ``*``) may not be supported by all file systems (e.g., on Windows) and as such should not be used as part of the names of Datasets or Groups as Zarr needs to create folders on the filesystem for these objects.
diff --git a/requirements-doc.txt b/requirements-doc.txt
@@ -1,6 +1,6 @@
 # dependencies to generate the documentation for HDMF
-sphinx
-sphinx_rtd_theme
-sphinx-gallery
-dandi
 matplotlib
+sphinx>=4  # improved support for docutils>=0.17
+sphinx_rtd_theme>=1  # <1 does not work with docutils>=0.17
+sphinx-gallery
+sphinx-copybutton
diff --git a/setup.py b/setup.py
@@ -22,7 +22,7 @@
     'numcodecs>=0.9.1',
     'pynwb>=2.0.0',
     'setuptools',
-    'numpy>=1.23; python_version >"3.7"'
+    'numpy>=1.22, <1.24; python_version>"3.7"'
 ]
 
 print(reqs)

diff --git a/test.py b/test.py
@@ -1,7 +1,6 @@
 #!/usr/bin/env python
 
 # NOTE this script is currently used in CI *only* to test the sphinx gallery examples using python test.py -e
-
 import warnings
 import re
 import argparse
@@ -67,19 +66,27 @@ def _import_from_file(script):
 def run_example_tests():
     global TOTAL, FAILURES, ERRORS
     logging.info('running example tests')
+
+    # get list of example scripts
     examples_scripts = list()
     for root, dirs, files in os.walk(os.path.join(os.path.dirname(__file__), "docs", "gallery")):
         for f in files:
             if f.endswith(".py"):
                 examples_scripts.append(os.path.join(root, f))
 
     TOTAL += len(examples_scripts)
+    curr_dir = os.getcwd()
     for script in examples_scripts:
+        os.chdir(curr_dir)  # Reset the working directory
+        script_abs = os.path.abspath(script)  # Determine the full path of the script
+        # Set the working dir to be relative to the script to allow the use of relative file paths in the scripts
+        os.chdir(os.path.dirname(script_abs))
         try:
             logging.info("Executing %s" % script)
             ws = list()
             with warnings.catch_warnings(record=True) as tmp:
-                _import_from_file(script)
+                # Import/run the example gallery
+                _import_from_file(script_abs)
                 for w in tmp:  # ignore RunTimeWarnings about importing
                     if isinstance(w.message, RuntimeWarning) and not warning_re.match(str(w.message)):
                         ws.append(w)
@@ -89,6 +96,8 @@ def run_example_tests():
             print(traceback.format_exc())
             FAILURES += 1
             ERRORS += 1
+    # Make sure to reset the working directory at the end
+    os.chdir(curr_dir)
 
 
 def main():