Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local copy of NWB file to avoid use of special characters in folder names #61

Merged
merged 21 commits into from
Jan 4, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 4, 2023

Fix #60

  • Add NWB file used in the conversion tutorial as a local asset (while replacing special characters not allowed on Windows)
  • Remove dandi as dependency for data download

@oruebel oruebel added category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users topic: docs Issues related to documentation labels Jan 4, 2023
@oruebel oruebel marked this pull request as ready for review January 4, 2023 01:10
@oruebel oruebel requested a review from mavaylon1 January 4, 2023 01:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 80.75% // Head: 80.59% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (aea3c02) compared to base (2ca0529).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           gallery_tests      #61      +/-   ##
=================================================
- Coverage          80.75%   80.59%   -0.17%     
=================================================
  Files                 10       10              
  Lines               2432     2437       +5     
=================================================
  Hits                1964     1964              
- Misses               468      473       +5     
Impacted Files Coverage Δ
test_gallery.py 29.16% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oruebel oruebel changed the base branch from dev to gallery_tests January 4, 2023 03:06
@oruebel oruebel merged commit 54d95d0 into gallery_tests Jan 4, 2023
@oruebel oruebel deleted the fix/gallery_convert_windows branch January 4, 2023 04:45
mavaylon1 added a commit that referenced this pull request Jan 4, 2023
* first

* Debug

* Revert "Debug"

This reverts commit 3d48d08.

* Remove test code changing current dir from the tutorial

* Update tox.ini

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update test_gallery.py

* Update test_gallery.py

* Update test_gallery.py

* test_gallery

* test_gallery

* test_gallery

* test_gallery

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update requirements-doc.txt

* Update CHANGELOG.md

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update setup.py

* Update plot_nwb_zarrio.py

* Update plot_nwb_zarrio.py

* Update plot_convert_nwb_hdf5.py

* Update plot_zarr_io.py

* Update plot_zarr_dataset_io.py

* Update plot_nwb_zarrio.py

* Update plot_zarr_dataset_io.py

* Update plot_convert_nwb_hdf5.py

* Use local copy of NWB file to avoid use of special characters in folder names (#61)

* Fix #60  Use local copy of NWB file to avoid use of special characters in folder names
* Remove DANDI as dependency for the docs
* Remove extraneous close calls for io objects closed automatically by with contexts
* Update test.py and test_gallery.py scripts to set consistent working directory for scripts
* Updated changelog

Co-authored-by: rly <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users topic: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid use of special characters in tutorial file
2 participants